Make Azure location configurable #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjementum
force-pushed
the
make-azure-location-configurable
branch
from
ed60aab to
59cd7ac
Compare
tjementum
force-pushed
the
make-azure-location-configurable
branch
2 times, most recently
from
f8c1485 to
61a3f38
Compare
tjementum
force-pushed
the
make-azure-location-configurable
branch
from
61a3f38 to
2228010
Compare
tjementum
force-pushed
the
make-azure-location-configurable
branch
13 times, most recently
from
cef2545 to
6c88c59
Compare
…rces to accept location as a parameter, deleting preconfigured scripts for West Europe
…, removing hardcoded West Europe location, making it configurable with GitHub environment variables
tjementum
force-pushed
the
make-azure-location-configurable
branch
from
6c88c59 to
fa809bc
Compare
…cated configuration and prepare for easy addition of additional clusters
…he new GitHub variables used by workflows
tjementum
force-pushed
the
make-azure-location-configurable
branch
from
fa809bc to
d156527
Compare
…ring correct subscription and location
…xt GitHub workflow
tjementum
force-pushed
the
make-azure-location-configurable
branch
from
c78689a to
ae7f611
Compare
platformplatformadmin
approved these changes
May 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Remove the hardcoded West Europe location when deploying Azure resources, making the location configurable using GitHub variables. This change allows for more flexible and dynamic deployment configurations and addresses the
AKSCapacityErrortriggered by the West Europe region running out of capacity for Azure Container Apps.Include a curated list of Azure Data Centers with names and acronyms that can be used for naming Azure resources (e.g.,
EastUs/eusandGermany West Central/gwc).Update the GitHub configuration to support different Azure subscriptions, splitting the Azure Service Principal used for deploying resources into separate ones for Staging and Production. This enhances security and management of deployment environments.
Grant the Service Principal for Staging and Production different permissions, e.g., only the Staging Service Principal can be used when detecting changes to infrastructure on pull requests, while the Production Service Principal can only be used when triggered from the
mainbranch.Remove deployment bash scripts like
production-west-europe.sh, consolidating all configurations into GitHub variables. This includes moving soft secrets likeTENANT_IDandSERVICE_PRINCIPAL_IDto the variables page. Now there are 2 shared variables (TENANT_IDandUNIQUE_PREFIX), 5 environment variables (likePRODUCTION_SUBSCRIPTION_ID,PRODUCTION_SERVICE_PRINCIPAL_ID,PRODUCTION_SHARED_LOCATION,PRODUCTION_SQL_ADMIN_OBJECT_ID, andPRODUCTION_DOMAIN_NAME), and 3 cluster variables (likePRODUCTION_CLUSTER1_LOCATION,PRODUCTION_CLUSTER1_LOCATION_ACRONYM, andPRODUCTION_CLUSTER1_ENABLED). TheENABLEDflag defaults to true for the Staging environment andfalsefor the Production environment.Extract a reusable GitHub workflow for deploying infrastructure, making adding new clusters as simple as duplicating one job in the
cloud-infrastructure.ymlfile and_deploy-container.ymland adding 3 GitHub variables likePRODUCTION_CLUSTER2_LOCATION,PRODUCTION_CLUSTER2_LOCATION_ACRONYM, andPRODUCTION_CLUSTER2_ENABLED.Major update to the
configure-continuous-deploymentsCLI command to collect the new information, making it more resilient to errors. It will no longer continue triggering GitHub actions if the previous workflow failed, and in case of errors, a clear message will be shown. Additionally, on success, it will now report how long the full deployment took.Checklist