Add board esp8285_2m for generic 8285 with 2MiB flash #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to get any comment on the best flash layout (eagle.flash.2m.ld vs eagle.flash.2m256.ld) for a generic 8285 board with 2mb flash, and to get this committed so that it is easier for others with 2mb 8285s to use the full 2mb in esphome (and other downstream stuff). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is identical to esp8285.json with two changes that bump the flash size from 1MiB to 2MiB:
The upload.maximum_size value of "2097152" is taken from modwifi.json which is another 2MiB flash board.
The build.arduino.ldscript value is modified from "eagle.flash.1m256.ld" to "eagle.flash.2m256.ld".
---- Though modwifi.json (another 2MiB board) uses "eagle.flash.2m.ld" instead of "eagle.flash.2m256.ld", I have no insight which partition layout is preferable and am choosing to mimic the 1MiB esp8285.json board definition on the assumption that this is the proper choice for a generic board.