Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shelly board #229

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Add Shelly board #229

wants to merge 5 commits into from

Conversation

GamerClassN7
Copy link

Shelly

@valeros valeros changed the title Shelly Add Shelly board Sep 3, 2020
@valeros
Copy link
Member

valeros commented Sep 3, 2020

Hi @GamerClassN7 ! I don't see this board in the official variant list https://github.com/esp8266/Arduino/tree/master/variants. We don't add boards that aren't officially supported.

@GamerClassN7
Copy link
Author

GamerClassN7 commented Sep 3, 2020

Hi @valeros there are sonoff board's they are supposed officially ?

@valeros
Copy link
Member

valeros commented Sep 3, 2020

At least they have a valid Arduino variant.

@GamerClassN7
Copy link
Author

Hi @valeros can you please point me what i am doing wrong ?
👍

"f_flash": "40000000L",
"flash_mode": "dout",
"mcu": "esp8266",
"variant": "shelly"
Copy link
Member

@valeros valeros Sep 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users won't be able to compile any project with this board since there is no such variant shelly in the Arduino core for ESP8266 https://github.com/esp8266/Arduino/tree/master/variants, but for some reason you specified -DARDUINO_ESP8266_SONOFF_S20. If the Shelly board is compatible with Sonoff S20 then you can use itead variant, pinout might be different though.

@GamerClassN7
Copy link
Author

@GamerClassN7 yes they are 8 and 9 different in this cas how to correctly add board ?

@valeros
Copy link
Member

valeros commented Sep 3, 2020

Do you want to reuse already supported variant or create a proper one for Shelly board?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants