Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #124. Adding link constraints to a graph with lots of variables was inefficient because of the
setdiff
call that was called by the_add_backend_variables
function (called byMOI.add_constraint
). I replaced thesetdiff
with a for loop that tests whether the variable is in the keys ofbackend.element_to_graph_map.var_map
rather than building a new vector of these variables first. The code snippet in #124 now works much quicker and the time for running each iteration of the loop in that issue no longer increases after each iteration.