Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contentstack package: Add limit and order to fetcher #54

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Thomas-Wesley-BSA
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Sep 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
contenful-example ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 4:13AM (UTC)
dynamic-multistep-forms ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 4:13AM (UTC)
plasmic ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 4:13AM (UTC)
plasmic-blog-example ❌ Failed (Inspect) Oct 19, 2022 at 4:13AM (UTC)
plasmic-blog-starter ❌ Failed (Inspect) Oct 19, 2022 at 4:13AM (UTC)
vercel-workflow ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 4:13AM (UTC)

@vercel
Copy link

vercel bot commented Sep 26, 2022

@Thomas-Wesley-BSA is attempting to deploy a commit to the Plasmic Team on Vercel.

A member of the Team first needs to authorize it.

@yang
Copy link
Contributor

yang commented Sep 29, 2022

Very cool!

@yang yang requested review from samuelfgs and guitubone September 29, 2022 20:08
@Thomas-Wesley-BSA Thomas-Wesley-BSA marked this pull request as draft October 10, 2022 05:31
@Thomas-Wesley-BSA
Copy link
Author

More wanted functionality came up at work today - namely ability to choose which field to match on for the "Entry UID" prop, with the current behavior (UID) being the default.

We want to use dynamic paths to pull a single entry, and this will let us use url/pretty-custom-slug instead of url/4f7ds89a7gre

I've drafted the PR until said functionality is done, then I'll reopen it.

@Thomas-Wesley-BSA
Copy link
Author

Done. It is only meant to work properly for string fields at the moment. It would be possible to fix this in the future, as we have access to the schema so there can be different behavior for string/number/boolean/etc... But to implement that properly the prop type will need to be dynamic, which it isn't at the moment (and I imagine would be a complicated change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants