Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for xml report #57

Merged
merged 8 commits into from
Nov 5, 2024
Merged

Conversation

Bizordec
Copy link
Contributor

I've used xmlreport.py from coverage.py as a base to add an XML support in slipcover (Cobertura-style format).

This resolves #6

src/slipcover/slipcover.py Fixed Show fixed Hide fixed
src/slipcover/xmlreport.py Fixed Show resolved Hide resolved
src/slipcover/xmlreport.py Fixed Show fixed Hide fixed
@emeryberger
Copy link
Member

Please check failure (ubuntu-latest, pypy-3.9).

@jaltmayerpizzorno
Copy link
Collaborator

Please check failure (ubuntu-latest, pypy-3.9).

I think this issue was present before this PR...

@Bizordec
Copy link
Contributor Author

Bizordec commented Nov 3, 2024

The test-build-from-source job is failing because there is no such directory starting with pp39 in manylinux container

python_tag: ['cp311', 'pp39']

Maybe change to cp39?

image

@jaltmayerpizzorno
Copy link
Collaborator

The test-build-from-source job is failing because there is no such directory starting with pp39 in manylinux container

python_tag: ['cp311', 'pp39']

Huh, it worked for me last week... https://github.com/plasma-umass/slipcover/actions/runs/11534857119/job/32109329650

But yes, it's a different container digest, and it looks like they moved to PyPy 3.10, deleting 3.9.

Maybe change to cp39?

Well, the point is to test building with PyPy. Let's see if SlipCover works with PyPy 3.10...

@Bizordec
Copy link
Contributor Author

Bizordec commented Nov 3, 2024

Huh, it worked for me last week... https://github.com/plasma-umass/slipcover/actions/runs/11534857119/job/32109329650

Looks like they dropped support for it 2 days ago
pypa/manylinux#1680

@jaltmayerpizzorno
Copy link
Collaborator

Looks like they dropped support for it 2 days ago pypa/manylinux#1680

Yup. We have tests failing with pypy 3.10... I'll look into that tomorrow.

@jaltmayerpizzorno
Copy link
Collaborator

Yup. We have tests failing with pypy 3.10... I'll look into that tomorrow.

Oh well, PyPy 3.10 implements its own line table format, different from cpython 3.9, cpython 3.10
and cpython 3.11. I implemented it, hopefully that will work now.

@jaltmayerpizzorno jaltmayerpizzorno merged commit 22a6420 into plasma-umass:main Nov 5, 2024
38 checks passed
@Bizordec
Copy link
Contributor Author

Could you please create a new release in PyPI? 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XML report
3 participants