feat(Rails7): Update for Rails 7 and MySQL 8 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcfadden
previously approved these changes
Aug 3, 2023
seven1m
force-pushed
the
7m/rails7
branch
5 times, most recently
from
1dd9a3f
to
50dfb6b
Compare
seven1m
changed the title
seven1m
changed the title
seven1m
dismissed stale reviews from mranallo and mcfadden
I made a bunch of changes :)
mcfadden
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to modernize the gem a little: getting it working on changes made in Rails 7 (and dropping support for older versions), and updating tests for MySQL 8.
We no longer retry on ActiveRecord::StatementTimeout errors.
I also took the opportunity to bump the version number to 1.0 and clean up the changelog.
Update 8/24/2023 by @bensie: There is new reconnect/retry functionality baked into Rails 7.1 (not yet released). This PR requires Rails 7.0.x under the assumption updating Rails will require the removal of this gem. Platform will provide guidance on this transition once 7.1 is released.