-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Rails7): Update for Rails 7 and MySQL 8 #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker at all, but should we set the version requirement on activerecord
here to >= 7
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😻
1dd9a3f
to
50dfb6b
Compare
I made a bunch of changes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So good! Thank you for breathing some life back into this.
This PR attempts to modernize the gem a little: getting it working on changes made in Rails 7 (and dropping support for older versions), and updating tests for MySQL 8.
We no longer retry on ActiveRecord::StatementTimeout errors.
I also took the opportunity to bump the version number to 1.0 and clean up the changelog.
Update 8/24/2023 by @bensie: There is new reconnect/retry functionality baked into Rails 7.1 (not yet released). This PR requires Rails 7.0.x under the assumption updating Rails will require the removal of this gem. Platform will provide guidance on this transition once 7.1 is released.