Skip to content

prerelease pipeline work #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 25, 2025
Merged

Conversation

carl-adams-planet
Copy link
Contributor

@carl-adams-planet carl-adams-planet commented Apr 25, 2025

Work on the build and release process prior to fully spinning up a 3.0 development branch.

This MR was developed with changes over at our readthedocs projects to better handle the documentation for pre-release versions.

Concrete changes in this MR:

  • Adding the version to the SDK doc's home page.
    • This is so docs are self contained - without this, it's not actually easy to know what version of the docs you are looking at without relying on outside framing.
    • This depends on updating to mkdocs 1.4
  • RELEASE.md updates
  • Read The Docs Content management notes

RELEASE.md Outdated
* `default`: [https://planet-sdk-for-python.readthedocs.io/](https://planet-sdk-for-python.readthedocs.io/) - Should point to same version as `stable`.
* `stable`: [https://planet-sdk-for-python.readthedocs.io/en/stable/](https://planet-sdk-for-python.readthedocs.io/en/stable/) - Should point to the highest stable release version.
* `latest`: [https://planet-sdk-for-python.readthedocs.io/en/latest/](https://planet-sdk-for-python.readthedocs.io/en/latest/) - Should point to the most recent build from `main`.
* _version_ : [https://planet-sdk-for-python.readthedocs.io/en/X.YY.ZZ/](https://planet-sdk-for-python.readthedocs.io/en/X.YY.Z/) - Should point to version `X.YY.ZZ`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should version have backticks? E.g. _version_.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh. That's not the nit I was wondering here. I was wondering...

  • "stable" and "latest" are literals. These are in URLs and such. I used monospace.
  • "version" is a place holder. I used italics for "your value here"
  • "default" is neither. both feel kinda wrong. Maybe italics more than monospace?

Copy link
Contributor Author

@carl-adams-planet carl-adams-planet Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could do both mono and italics. I kinda see that. Changing to that.

I think that sometimes renders funny.

  • backtick underbar : _version_
  • underbar backtick: version
  • backtick only : version
  • underbar only : version

This is why Ora books have a whole preface on type conventions.

(and as your response shows, markdown is finicky as to the order of wrapping. That amuses me because that's exactly why Ye Olde HTML of 1994 evolved into more rigorous XML variants. I've always harbored a believe that Markdown forgot that history.)

No strong feelings. Consistency over nit picking here for me. What does the rest of the doc site do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change applied.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Your explanation about stable/latest vs version being a placeholder makes a lot of sense! My original comment is about consistency with the other properties in the list. I think keeping version as is makes a lot of sense now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. Markdown isn't LaTeX. Sadly.

Copy link
Contributor

@asonnenschein asonnenschein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carl-adams-planet carl-adams-planet merged commit 2ada91e into main Apr 25, 2025
9 checks passed
@carl-adams-planet carl-adams-planet deleted the carl/prerelease-pipeline-work--pr branch April 25, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants