Vanish requests #29
Merged
Vanish requests #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mplorentz
approved these changes
Oct 15, 2024
src/getRedisClient.js
Outdated
| @@ -25,11 +25,33 @@ async function initializeRedis() { | |||
| } | |||
| } | |||
|
|
|||
| async function getRedisClient() { | |||
| async function initializeRemoteRedis() { | |||
There was a problem hiding this comment.
I find "local" and "remote" redis a little confusing. Is the local redis for storing name/pubkey pairs, and remote is for the vanish requests? I think this could use some more documentation at least. Maybe even a rename to "nameRedis" and "vanishRequestRedis" or something like that would be good.
And ideally someday we can refactor down to one Redis instance?
There was a problem hiding this comment.
oh yeah, down in src/server.js they have nicer names.
There was a problem hiding this comment.
I renamed them to getNip05RedisClient and getVanishRequestsRedisClient. We can always get back to it if we ever add more use cases and we don't migrate to the DO db.
src/nameRecordRepository.js
Outdated
| count: 1000, | ||
| }); | ||
|
|
||
| let processingPromises = []; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
vanish_requestsstream subscription to remove info for specific pubkeys. This is for https://github.com/planetary-social/infrastructure/issues/139