Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CarBasicConfiguration): update UseFleetTelemetryForLocationData helpter text #1631

Merged
merged 1 commit into from
Nov 17, 2024
Merged

feat(CarBasicConfiguration): update UseFleetTelemetryForLocationData helpter text #1631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TeslaSolarCharger/Shared/Dtos/CarBasicConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

public class CarBasicConfiguration
{
public CarBasicConfiguration()

Check warning on line 9 in TeslaSolarCharger/Shared/Dtos/CarBasicConfiguration.cs

View workflow job for this annotation

GitHub Actions / Building TeslaSolarCharger image 

Non-nullable property 'Vin' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
{
}

Expand Down Expand Up @@ -53,6 +53,6 @@
[HelperText("If enabled, some data will be transferred via Fleet Telemetry. This improves the delay in the TSC detection of plugin and out of the car, as well as changes in the charging speed. Note: All data transferred via Fleet Telemetry passes my server. For now, the fleet telemetry fields ModuleTempMin, ModuleTempMax,ChargeAmps, ChargeCurrentRequest, ChargeCurrentRequestMax, DetailedChargeState are requested.")]
public bool UseFleetTelemetry { get; set; }

[HelperText("Enabling this results in additionally streaming the field Location over my server. If disabled and TeslaMate is not selected as DataSource TSC takes up to 8 minutes to detect if the car is at home. If you do not mind that your car location data passes my server, do not disable this option.")]
[HelperText("This further improves the detection if the car is at home. Enabling this results in additionally streaming the field Location over my server. If you do not mind that your car location data passes my server, do not disable this option.")]
public bool UseFleetTelemetryForLocationData { get; set; } = true;
}
Loading