Fix tooltips being displayed despite page/subpage change #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
=======================================
Coverage 76.17% 76.17%
=======================================
Files 92 92
Lines 5242 5242
=======================================
Hits 3993 3993
Misses 1249 1249 ☔ View full report in Codecov by Sentry. |
martinjrobins
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SubPages enum;
Added selectedSubPage to store;
Added setting selectedSubPage on subPage change and on page change when Page has DynamicTabs;
Fixed tooltip being displayed despite page/subpage being changed;
Added Pointer cursor on tooltip Close icon