UI changes accordingly to Figma mockups #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 19, 2023 11:07
…ed Vertical/Horizontal views to Simulations tab; changed dialog box on Help button to tooltip
# Conflicts: # frontend-v2/src/components/TextField.tsx # frontend-v2/src/features/main/Sidebar.tsx # frontend-v2/src/features/simulation/Simulations.tsx
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #324 +/- ##
=======================================
Coverage 76.17% 76.17%
=======================================
Files 92 92
Lines 5242 5242
=======================================
Hits 3993 3993
Misses 1249 1249 ☔ View full report in Codecov by Sentry. |
martinjrobins
previously approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Thanks @wniestroj, this looks great. Love the toast info on the parameters page, we'll have to think of other context dependent info to add!
Since this is an open-source project, I'd like to have the roche logo be an optional deployment choice, is there a nice way we can do this?
Co-authored-by: Martin Robinson <[email protected]>
added 3 commits
December 19, 2023 14:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI changes accordingly to Figma mockups, added notifcations hook, added sticky Vertical/Horizontal views for Parameters to Simulations tab; changed dialog box on Help button to tooltip