pkp/pkp-lib#4787 Reviewer suggestions

[touhidurabir]

for pkp/pkp-lib#4787

[defstat]

Thanks @touhidurabir! Not much here.

Questions:

In the "REVIEWER SUGGESTIONS" there is a drop down control that has a "More Actions" indicator. Should that be a three-dot button doing the same thing?

Also I am wondering whether the newly upgraded TinyMCE affects in any way the forms that are being used in this feature, or rather whether we need to consider changes in this issues PRs regarding the upgraded TinyMCE component.

[touhidurabir]

Thanks @touhidurabir! Not much here.

Questions:

In the "REVIEWER SUGGESTIONS" there is a drop down control that has a "More Actions" indicator. Should that be a three-dot button doing the same thing?

Also I am wondering whether the newly upgraded TinyMCE affects in any way the forms that are being used in this feature, or rather whether we need to consider changes in this issues PRs regarding the upgraded TinyMCE component.

This has broken due to some new changes in the ui lib , otherwise this is how it should be and was previously

[asmecher]

@blesildaramirez, it looks like some TinyMCE changes might be needed here -- can you spot anything quickly that needs adaptation for the new version?

[touhidurabir]

@blesildaramirez, it looks like some TinyMCE changes might be needed here -- can you spot anything quickly that needs adaptation for the new version?

This does not seems like anything related to TinyMce but some changes to the DropdownActions component and the fix is very simple .

[asmecher]

This does not seems like anything related to TinyMce but some changes to the DropdownActions component and the fix is very simple .

Thanks, @touhidurabir -- do you mean a simple fix that you can tackle, or that you'll need someone to take care of in ui-library?

[touhidurabir]

This does not seems like anything related to TinyMce but some changes to the DropdownActions component and the fix is very simple .

Thanks, @touhidurabir -- do you mean a simple fix that you can tackle, or that you'll need someone to take care of in ui-library?

I have already fixed it . Working on the PR update based on code review .

[defstat]

Thanks @touhidurabir! Can you check this scenario?

When in Review Round workflow, click on "Add Reviewer". In the modal that appears, click "Select Reviewer" from the "Select a Reviewer from Reviewer Suggestions" grid. In the "Add Reviewer" modal, try to click on "Files To Be Reviewed". The button seems not to work as it supposed to though.

[touhidurabir]

Thanks @touhidurabir! Can you check this scenario?

When in Review Round workflow, click on "Add Reviewer". In the modal that appears, click "Select Reviewer" from the "Select a Reviewer from Reviewer Suggestions" grid. In the "Add Reviewer" modal, try to click on "Files To Be Reviewed". The button seems not to work as it supposed to though.

great spot of this case as only happening from Add Reviewer modal of all reviewers and also again only for suggestion or existing user with no reviewer role . Should be fixed with last commit .