pkp/pkp-lib/issues/6201 Adapt to support OMP #79
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| .citation_display .value | ||
| { | ||
| font-size: 0.75rem; | ||
| } | ||
|
|
||
| .citation_display .csl-left-margin | ||
| { | ||
| display: none; | ||
| } | ||
|
|
||
| .citation_display [aria-hidden="true"] | ||
| { | ||
| display: none; | ||
| } | ||
|
|
||
| .citation_display .citation_formats | ||
| { | ||
| margin-top: 1em; | ||
| border: 1px solid rgba(0, 0, 0, 0.4); | ||
| border-radius: 2px; | ||
| } | ||
|
|
||
| .citation_display .citation_formats_button | ||
| { | ||
| position: relative; | ||
| background: transparent; | ||
| border: none; | ||
| border-bottom-left-radius: 0; | ||
| border-bottom-right-radius: 0; | ||
| box-shadow: none; | ||
| padding: 0 1em; | ||
| width: 100%; | ||
| font-family: "Noto Sans", -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif; | ||
| font-weight: 400; | ||
| color: #777; | ||
| text-align: left; | ||
| } | ||
|
|
||
| .citation_display .citation_formats_button:after | ||
| { | ||
| display: inline-block; | ||
| font: normal normal normal 14px/1 FontAwesome; | ||
| font-size: inherit; | ||
| text-rendering: auto; | ||
| -webkit-font-smoothing: antialiased; | ||
| -moz-osx-font-smoothing: grayscale; | ||
| content: "\f0d7"; | ||
| position: absolute; | ||
| top: 50%; | ||
| right: 1em; | ||
| transform: translate(0, -50%); | ||
| } | ||
| .citation_display .citation_formats_button[aria-expanded="true"]:after | ||
| { | ||
| content: "\f0d8"; | ||
| } | ||
|
|
||
| .citation_display .citation_formats_button:focus | ||
| { | ||
| background: #ddd; | ||
| outline: 0; | ||
| } | ||
|
|
||
| .citation_display .citation_formats_styles | ||
| { | ||
| margin: 0; | ||
| padding: 0; | ||
| list-style: none; | ||
| } | ||
|
|
||
| .citation_display .citation_formats_styles a | ||
| { | ||
| display: block; | ||
| padding: 0.5em 1em; | ||
| border-bottom: 1px solid #bbb; | ||
| text-decoration: none; | ||
| } | ||
|
|
||
| .citation_display .citation_formats_styles a:focus | ||
| { | ||
| background: #ddd; | ||
| outline: 0; | ||
| } | ||
|
|
||
| .citation_display .citation_formats_styles li:last-child a | ||
| { | ||
| border-bottom: none; | ||
| } | ||
|
|
||
| .citation_display .citation_formats_list .label | ||
| { | ||
| padding: 1em 1em 0.25em 1em; | ||
| } | ||
|
|
||
| .citation_display .citation_formats_styles + .label | ||
| { | ||
| border-top: 1px solid #bbb; | ||
| } | ||
|
|
||
| .citation_display span | ||
| { | ||
| margin-right: 0.5em; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| {* How to cite *} | ||
| {if $citation} | ||
| <div class="item citation"> | ||
| <section class="sub_item citation_display"> | ||
| <h2 class="label"> | ||
| {translate key="submission.howToCite"} | ||
| </h2> | ||
| <div class="value"> | ||
| <div id="citationOutput" role="region" aria-live="polite"> | ||
| {$citation} | ||
| </div> | ||
| <div class="citation_formats"> | ||
| <button class="cmp_button citation_formats_button" aria-controls="cslCitationFormats" aria-expanded="false" data-csl-dropdown="true"> | ||
| {translate key="submission.howToCite.citationFormats"} | ||
| </button> | ||
| <div id="cslCitationFormats" class="citation_formats_list" aria-hidden="true"> | ||
| <ul class="citation_formats_styles"> | ||
| {foreach from=$citationStyles item="citationStyle"} | ||
| <li> | ||
| <a | ||
| aria-controls="citationOutput" | ||
| href="{url page="citationstylelanguage" op="get" path=$citationStyle.id params=$citationArgs}" | ||
| data-load-citation | ||
| data-json-href="{url page="citationstylelanguage" op="get" path=$citationStyle.id params=$citationArgsJson}" | ||
| > | ||
| {$citationStyle.title|escape} | ||
| </a> | ||
| </li> | ||
| {/foreach} | ||
| </ul> | ||
| {if count($citationDownloads)} | ||
| <div class="label"> | ||
| {translate key="submission.howToCite.downloadCitation"} | ||
| </div> | ||
| <ul class="citation_formats_styles"> | ||
| {foreach from=$citationDownloads item="citationDownload"} | ||
| <li> | ||
| <a href="{url page="citationstylelanguage" op="download" path=$citationDownload.id params=$citationArgs}"> | ||
| <span class="fa fa-download"></span> | ||
| {$citationDownload.title|escape} | ||
| </a> | ||
| </li> | ||
| {/foreach} | ||
| </ul> | ||
| {/if} | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </section> | ||
| </div> | ||
| {/if} | ||
|
There was a problem hiding this comment. We're going to end up with this template code (and the CSS code) duplicated across OJS/OMP. But each application will have it stored in a different place. Let's try to bring these into alignment if possible. I like that your template/css code is stored in the plugin. Let's see if we can duplicate this in OJS as well. One way to do that is to include this template from the That way both will be loading from the plugin. We can then remove the CSS styles from OJS's default theme and rely on the ones in this plugin. We should do the same with the JS code that makes it go (this is in the default theme right now). There was a problem hiding this comment. That's fine with me! Do you change the article_details.tpl? I will do it the same way in the template for the OMP chapter landing pages, what I'm also working on. Are you sure, that there is JS code for this plugin in the theme? I thought it's all in the plugin. (see here) There was a problem hiding this comment. You're right! I thought that this used the dropdown JavaScript code from the default theme but it looks like it doesn't. |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to be a little more careful about how we're interacting with non-default themes. This would override the theme's existing font selection. I can think of a couple ways around this:
I'm happy to talk through these options with you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer option one, because then the syle for the plugin is in the plugin. I've made some changes in the css file, so there shouldn't be problems with non-default themes any more. Only font size for the names of the citation styles in the dropdown and neccessary instructions for the arrow by FontAwesome are set by the plugin, now. Color instructions are also only set for some borders of dropdown.