Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install pkl on GitHub codespaces #58

Open
StefMa opened this issue Oct 8, 2024 · 3 comments
Open

Install pkl on GitHub codespaces #58

StefMa opened this issue Oct 8, 2024 · 3 comments
Assignees

Comments

@StefMa
Copy link
Contributor

StefMa commented Oct 8, 2024

After #47 got merged, we should install pkl automatically when setting up a github codespace.
This make sure that each and every script can run without any problems.

@jasongwartz
Copy link
Contributor

@StefMa Why does it depend on #47 ? And would you be interested in taking on the task?

@StefMa
Copy link
Contributor Author

StefMa commented Oct 8, 2024

It doesn't depend on #47, true.
But it is not needed before that got merged.

Yes, I would love to do that 🙂

@StefMa
Copy link
Contributor Author

StefMa commented Oct 11, 2024

Be note that this is the first time I customize codespaces.

So I just read up on this a little bit, and until pkl is not availble in the official VS Code Marketplace (see apple/pkl-vscode#9) it is quite "hard" to add pkl to a codespace.

However, so far I found two options:

  1. Just put a single line bash command to one of the commands (see https://containers.dev/implementors/json_reference/#lifecycle-scripts). But here I don't know which one to choose (yet) 😅 .
  2. Create a new repo and create a custom feature (see https://code.visualstudio.com/blogs/2022/09/15/dev-container-features#_authoring & https://github.com/devcontainers/feature-starter/tree/67a45f05bb47843fef96f53ab09eab04680f6d95/src/color).

The latter looks quite nice to me since we can simply add this feature to the devcontainer.json afterwards like:

features : { http://github.com..../pkl-feature }

(or so 😁 )

But I'm not sure if this is a bit overkill.
Also given that the pkl authors will push to the official Marketplace (hopefully) anyways.
If this would be the case, we can simply add it via

extensions : { "pkl" }

and done...

But as long this is not the case we have to workaround it.

Does anyone have any opinion/recommendation how to do that in a nice way? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants