Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update node.js to v22 #143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update node.js to v22 #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,6 @@
},
"support": true,
"engines": {
"node": "^16 || ^14 || ^12"
"node": "^22.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be able to run on the latest LTS

Suggested change
"node": "^22.0.0"
"node": "^16 || ^14 || ^12 || >=18"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this version is better since it isn't breaking.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesleytodd Is there a maintainer for this package? If not, I’d be willing to maintain it since I’m testing it for Express.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hasn't had any action in ages, so yeah, if it works for you - you can keep this puppy 😁

Officially it's owned by the package maintenance working group, but I'm sure membership can be sorted out. It looks like I own https://github.com/wiby if it was decided to move this out.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, although well, @wesleytodd or an administrative member will have to give me write access. Currently, I am a 'member' but I don't have the necessary permissions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty unopinionated about where it lives. @dominykas I assume you are not working on it anymore? It seems easiest to keep it here and add @bjohansebas as a comitter on the repo (an easy change I can make) but we had some policies in place for this and I am not sure how we want to apply them since the project is partly abandoned at the moment. IMO it would be best to just add @bjohansebas, but maybe we would need to run that by the broader group?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you are not working on it anymore?

Not for the past while...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that you have policies, just like other organizations do, but couldn't this discussion be taken offline? Maybe in an issue? In the end, several of these packages are somewhat abandoned, and I have offered to maintain them because they are useful to me. I have been patient, waiting for a response on whether I can maintain them. If not, I will choose another path.

}
}