Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix yt-dlp issues again lol #4

Merged
merged 3 commits into from
Oct 21, 2024
Merged

fix yt-dlp issues again lol #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d4beaf
strip mpv binary
Samueru-sama Oct 20, 2024
e671951
Update blank2.yml
Samueru-sama Oct 20, 2024
2b772cc
Update blank2.yml
Samueru-sama Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/blank2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
build:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4

Expand All @@ -21,7 +21,7 @@ jobs:
sudo apt install equivs libavutil-dev libavcodec-dev libswscale-dev python3-dev cython3 g++ nasm git libavfilter-dev libxmu-dev libxcb1-dev
sudo apt install libfuse2 libdbus-1-dev libx11-dev libxinerama-dev libxrandr-dev yasm intltool autoconf libtool devscripts libass-dev libx264-dev
sudo apt install libxss-dev libglib2.0-dev libpango1.0-dev libgtk-3-dev libxdg-basedir-dev libnotify-dev libc++-dev libplacebo-dev libx265-dev
sudo apt install ninja-build autotools-dev autoconf automake make build-essential pkg-config python3-pip desktop-file-utils zsync
sudo apt install ninja-build autotools-dev autoconf automake make build-essential pkg-config python3-pip desktop-file-utils zsync binutils
sudo pip3 install packaging meson
chmod a+x ./mpv-AppImage.sh && ./mpv-AppImage.sh
mkdir dist
Expand Down
3 changes: 3 additions & 0 deletions mpv-AppImage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ sed -i 's/export PYTHONHOME/#export PYTHONHOME/g' ./mpv.AppDir/AppRun
# Likely go-appimage breaking something
cp /lib64/ld-linux-x86-64.so.2 ./mpv.AppDir/lib64/ld-linux-x86-64.so.2 || exit 1

# go appimage is not stripping the main binary
strip --strip-unneeded ./mpv.AppDir/usr/bin/mpv || exit 1

# maybe not needed but I had appimagetool bug out before if the AppDir isnt in the top level of home
mv ./mpv.AppDir ../ && cd ../ || exit 1

Expand Down
Loading