Avoid self release for NSWindow, NSWindowController, NSView

git-svn-id: https://svn.code.sf.net/p/osirixplugins/code@206 bdd3870d-6ba2-4b59-8605-1de7af000970
pixmeo · Mar 23, 2012 · f9610c2 · f9610c2
1 parent 213c621
commit f9610c2
Show file tree

Hide file tree

Showing 22 changed files with 32 additions and 28 deletions.
diff --git a/64bit/64bit.xcodeproj/project.pbxproj b/64bit/64bit.xcodeproj/project.pbxproj
@@ -144,7 +144,11 @@
 			isa = PBXProject;
 			buildConfigurationList = C01FCF4E08A954540054247B /* Build configuration list for PBXProject "64bit" */;
 			compatibilityVersion = "Xcode 3.0";
+			developmentRegion = English;
 			hasScannedForEncodings = 1;
+			knownRegions = (
+				en,
+			);
 			mainGroup = 29B97314FDCFA39411CA2CEA /* 64bit */;
 			projectDirPath = "";
 			projectRoot = "";
@@ -236,7 +240,7 @@
 				GCC_WARN_ABOUT_RETURN_TYPE = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
 				PREBINDING = NO;
-				SDKROOT = "$(DEVELOPER_SDK_DIR)/MacOSX10.5.sdk";
+				SDKROOT = macosx10.6;
 			};
 			name = Debug;
 		};
@@ -253,7 +257,7 @@
 				GCC_WARN_UNUSED_VARIABLE = YES;
 				MACOSX_DEPLOYMENT_TARGET = 10.5;
 				PREBINDING = NO;
-				SDKROOT = "$(DEVELOPER_SDK_DIR)/MacOSX10.5.sdk";
+				SDKROOT = macosx10.6;
 			};
 			name = Release;
 		};

diff --git a/BullsEye/BullsEyeController.m b/BullsEye/BullsEyeController.m
@@ -41,7 +41,7 @@ - (void) windowWillClose:(NSNotification*)notification
 		[[NSUserDefaults standardUserDefaults] setValue: [presetsList arrangedObjects] forKey: @"presetsBullsEyeList"];
 
 		[[self window] orderOut: self];
-		[self release];
+		[self autorelease];
 	}
 }
 - (IBAction) refresh: (id) sender

diff --git a/CMIR_T2_Fit_Map/Controller.m b/CMIR_T2_Fit_Map/Controller.m
@@ -974,7 +974,7 @@ - (void) closeViewer :(NSNotification*) note
 	{
 		NSLog(@"Viewer Window will close.... We have to close!");
 
-		[self release];
+		[self autorelease];
 	}
 
 	if( [note object] == new2DViewer)
@@ -987,7 +987,7 @@ - (void)windowWillClose:(NSNotification *)notification
 {
 	NSLog(@"Window will close.... and release his memory...");
 
-	[self release];
+	[self autorelease];
 }
 
 - (void) dealloc

diff --git a/CMIV_CTA_TOOLS/CMIVChopperController.mm b/CMIV_CTA_TOOLS/CMIVChopperController.mm
@@ -146,7 +146,7 @@ - (void)windowWillClose:(NSNotification *)notification
 	[originalViewController release];
 	[originalViewVolumeData release];
 	[originalViewPixList release];
-	[self release];
+	[self autorelease];
 
 }
 - (int)reduceTheVolume:(NSArray*)bordersArray:(ViewerController *) vc

diff --git a/CMIV_CTA_TOOLS/CMIVContrastPreview.mm b/CMIV_CTA_TOOLS/CMIVContrastPreview.mm
@@ -464,7 +464,7 @@ - (void)windowWillClose:(NSNotification *)notification
 	if(parentColorData)    								
 		[parentColorData     release];
 
-	[self release];
+	[self autorelease];
 }
 -(void) dealloc
 {

diff --git a/CMIV_CTA_TOOLS/CMIVScissorsController.mm b/CMIV_CTA_TOOLS/CMIVScissorsController.mm
@@ -231,7 +231,7 @@ - (void)windowWillClose:(NSNotification *)notification
 		[centerlinesLengthArrays release];
 	[seedToolTipsTabView setDelegate:nil];
 
-	[self release];
+	[self autorelease];
 
 }
 -(void) dealloc

diff --git a/CMIV_CTA_TOOLS/CMIVVRcontroller.mm b/CMIV_CTA_TOOLS/CMIVVRcontroller.mm
@@ -398,7 +398,7 @@ - (void)windowWillClose:(NSNotification *)notification
 		[originalViewController release];
 		[originalViewVolumeData release];
 		[originalViewPixList release];
-		[self release];
+		[self autorelease];
 
 	}	
 }

diff --git a/CSB_Multi_Fusion/Controller.m b/CSB_Multi_Fusion/Controller.m
@@ -288,7 +288,7 @@ - (void)windowWillClose:(NSNotification *)notification
 {
 	NSLog(@"CSB_Multi_Fusion: Window will close.... and release his memory...");
 
-	[self release];
+	[self autorelease];
 
 }
 

diff --git a/CardiacStatistics/SectorManagerController.m b/CardiacStatistics/SectorManagerController.m
@@ -252,7 +252,7 @@ - (void)windowWillClose:(NSNotification *)notification
 
 	NSLog( @"ROIManager windowWillClose");
 
-	[self release];
+	[self autorelease];
 }
 
 - (void) dealloc

diff --git a/Coronary/CoronaryController.m b/Coronary/CoronaryController.m
@@ -41,7 +41,7 @@ - (void) windowWillClose:(NSNotification*)notification
 		[[NSUserDefaults standardUserDefaults] setValue: [presetsList arrangedObjects] forKey: @"presetsCoronaryList"];
 
 		[[self window] orderOut: self];
-		[self release];
+		[self autorelease];
 	}
 }
 - (IBAction) refresh: (id) sender

diff --git a/Ejection Fraction/Sources/EjectionFractionResultsController.mm b/Ejection Fraction/Sources/EjectionFractionResultsController.mm
@@ -222,7 +222,7 @@ -(id)initWithWorkflow:(EjectionFractionWorkflow*)workflow {
 -(void)windowWillClose:(NSNotification*)notification {
 //	NSLog(@"results windowWillClose, rc = %d, win rc = %d", [self retainCount], [[self window] retainCount]);
 	NSLog(@"results controller window will close, my rc is %d", [self retainCount]);
-	[self release]; // TODO: this is UNSAFE, [NSWindow dealloc] should release the controller? the problem is, NSWindow's retain count is huge, so it won't be released
+	[self autorelease]; // TODO: this is UNSAFE, [NSWindow dealloc] should release the controller? the problem is, NSWindow's retain count is huge, so it won't be released
 }
 
 -(void)dealloc {

diff --git a/HipArthroplastyTemplating/Sources/ArthroplastyTemplatingStepsController.mm b/HipArthroplastyTemplating/Sources/ArthroplastyTemplatingStepsController.mm
@@ -156,7 +156,7 @@ -(NSString*)windowFrameAutosaveName {
 #pragma mark Windows
 
 - (void)windowWillClose:(NSNotification *)aNotification { // this window is closing
-	[self release];
+	[self autorelease];
 }
 
 - (void)viewerWillClose:(NSNotification*)notification {

diff --git a/HipArthroplastyTemplating/Sources/ArthroplastyTemplatingWindowController.mm b/HipArthroplastyTemplating/Sources/ArthroplastyTemplatingWindowController.mm
@@ -66,7 +66,7 @@ -(NSString*)windowFrameAutosaveName {
 }
 
 -(void)windowWillClose:(NSNotification *)aNotification {
-	// [self release];
+	// [self autorelease];
 }
 
 //-(NSSize)windowWillResize:(NSWindow*)window toSize:(NSSize)size {

diff --git a/Invert - WindowController/ThanksController.m b/Invert - WindowController/ThanksController.m
@@ -30,7 +30,7 @@ - (void)windowWillClose:(NSNotification *)notification
 {
 	NSLog(@"Window will close.... and release his memory...");
 
-	[self release];
+	[self autorelease];
 }
 
 - (void) dealloc

diff --git a/MIRC Teaching File/SGAudioSettings.mm b/MIRC Teaching File/SGAudioSettings.mm
@@ -181,7 +181,7 @@ - (id)initWithSGChan:(SGAudio *)wrapper
 
     if (!wrapper)
     {
-        [self release];
+        [self autorelease];
         self = nil;
     }
     else {

diff --git a/OpenGL/OpenGLController.m b/OpenGL/OpenGLController.m
@@ -28,7 +28,7 @@ - (void)windowWillClose:(NSNotification *)notification
 {
 	NSLog(@"Window will close.... and release his memory...");
 
-	[self release];
+	[self autorelease];
 }
 
 - (void) dealloc

diff --git a/PetSpectFusion/PSFSettingsWindowController.mm b/PetSpectFusion/PSFSettingsWindowController.mm
@@ -297,15 +297,15 @@ - (void)windowWillClose:(NSNotification *)notification
 {
 	DebugLog(@"SettingsWindowController close");
 	[[NSNotificationCenter defaultCenter] removeObserver:self];
-	[self release];
+	[self autorelease];
 
 }
 
 - (void) viewerWillClose:(NSNotification*)notification
 {
 	DebugLog(@"One of the necessary viewers have closed");
 	[[NSNotificationCenter defaultCenter] removeObserver:self];
-	[self release];
+	[self autorelease];
 }
 
 - (void) levelChanged:(RegUpdate*) updateParams

diff --git a/ROI Enhancement II/Sources/RoiEnhancementInterface.mm b/ROI Enhancement II/Sources/RoiEnhancementInterface.mm
@@ -73,7 +73,7 @@ -(void)windowWillClose:(NSNotification*)notification {
 	if ([notification object] == [self window]) {
 		_chart.stopDraw = YES;
 		[[self window] orderOut: self];
-		[self release];
+		[self autorelease];
 	}
 }
 

diff --git a/T1 Fit Map/Controller.m b/T1 Fit Map/Controller.m
@@ -481,7 +481,7 @@ - (void) closeViewer :(NSNotification*) note
 	{
 		NSLog(@"Viewer Window will close.... We have to close!");
 
-		[self release];
+		[self autorelease];
 	}
 
 	if( [note object] == new2DViewer)
@@ -494,7 +494,7 @@ - (void)windowWillClose:(NSNotification *)notification
 {
 	NSLog(@"Window will close.... and release his memory...");
 
-	[self release];
+	[self autorelease];
 }
 
 - (void) dealloc

diff --git a/T2 Fit Map/Controller.m b/T2 Fit Map/Controller.m
@@ -553,7 +553,7 @@ - (void) closeViewer :(NSNotification*) note
 	{
 		NSLog(@"Viewer Window will close.... We have to close!");
 
-		[self release];
+		[self autorelease];
 	}
 
 	if( [note object] == new2DViewer)
@@ -566,7 +566,7 @@ - (void)windowWillClose:(NSNotification *)notification
 {
 	NSLog(@"Window will close.... and release his memory...");
 
-	[self release];
+	[self autorelease];
 }
 
 - (void) dealloc

diff --git a/T2 Ratio Map/Controller.m b/T2 Ratio Map/Controller.m
@@ -227,7 +227,7 @@ - (void)windowWillClose:(NSNotification *)notification
 {
 	NSLog(@"Window will close.... and release his memory...");
 
-	[self release];
+	[self autorelease];
 }
 
 - (void) dealloc

diff --git a/Volume Calculator/ControllerVolumeCalculator.m b/Volume Calculator/ControllerVolumeCalculator.m
@@ -225,14 +225,14 @@ - (void) closeViewer :(NSNotification*) note
 	if( [note object] == [filter viewerController])
 	{
 		[[NSNotificationCenter defaultCenter] removeObserver: self];
-		[self release];
+		[self autorelease];
 	}
 }
 
 - (void)windowWillClose:(NSNotification *)notification
 {
 	[[NSNotificationCenter defaultCenter] removeObserver: self];
-	[self release];
+	[self autorelease];
 }
 
 - (void) dealloc
-Original file line number
+Diff line change
@@ Expand Up / @@ -288,7 +288,7 @@ - (void)windowWillClose:(NSNotification *)notification @@
     {
     	NSLog(@"CSB_Multi_Fusion: Window will close.... and release his memory...");
-    	[self release];
+    	[self autorelease];
     }
@@ Expand Down @@