This repository has been archived by the owner on May 14, 2024. It is now read-only.
Update help message #357
Merged
Update help message #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update help text for add_sus and subtract_sus to be more specific
Comeani
reviewed
Dec 20, 2023
There was a problem hiding this comment.
The only consideration I would make here with the wording is that the service units are not subtracted across all of the clusters per se, but the "all clusters" allocation. i.e. crc-bank proposal add_sus sam --all-clusters 500 != crc-bank proposal add_sus sam --smp 500 --mpi 500 --htc 500 --gpu 500 even though it technically achieves the same effect.
|
Changed relevant part of the help text to 'all-clusters allocation' |
Added error message if unlock run without sudo privilege
|
Also added error message when unlock is run without sudo privileg, addressing issue #355 |
Comeani
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update help text for add_sus and subtract_sus to be more specific