This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
User Home Dir Check Removal #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djperrefort
suggested changes
Oct 5, 2023
There was a problem hiding this comment.
The updated source code looks fine, but you also need to update the test suite to reflect your changes. In this case, that involves removing the tests that target the deleted functionality. If you scroll to the bottom of the PR, you'll see the test suite is failing. The branch protection rules on this repository will not let a PR be merged with a failing test.
Please also update the README by removing instructions relevant to the missing user redirect.
|
Okay, will work on that. |
Removing the part of the code checking for the presence of a home directory for the authenticated user. This was dedicated for Jupyterhub running on a host machine before; however, we changed the implementation to containerized Jupyterhub which provisions a unified container for each user with its dedicated home dir.
yassinkhalifa
force-pushed
the
user-home-dir-checking
branch
from
3499e4d
to
a3afdcc
Compare
djperrefort
approved these changes
Oct 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the part of the code checking for the presence of a home directory for the authenticated user. This was dedicated for Jupyterhub running on a host machine before; however, we changed the implementation to containerized Jupyterhub which provisions a unified container for each user with its dedicated home dir.