Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mrpossoms/silva adaptive download links #21

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mrpossoms
Copy link

Use beautifulsoup to scrape download links from file listing webpages. Anchor tags whose href attribute matches a regex pattern are returned as download link candidates. This will allow dataset downloads to better adapt to version and organizational changes without interruption of normal functionality.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.21%. Comparing base (876d1ac) to head (c996fd2).
Report is 4 commits behind head on main.

Files Patch % Lines
multitax/utils.py 84.61% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   95.38%   95.21%   -0.18%     
==========================================
  Files          10       10              
  Lines         824      836      +12     
==========================================
+ Hits          786      796      +10     
- Misses         38       40       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pirovc
Copy link
Owner

pirovc commented Aug 28, 2024

Nice! Thanks for the PR. The BeautifulSoup package is very limited in terms of compatibility with python versions, almost all tests failed. Is there a way to achieve the same without it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants