Add RimeTTSService #1163
Add RimeTTSService #1163
Conversation
|
@aconchillo good feedback! I updated those points. I'm seeing an issue with the word timings. I think the timings are faster than the audio stream which results in: 1) incorrectly timed onTtsText callbacks (for RTVI), 2) not getting the complete text into the LLM context. I reached out to Rime to see if this is an issue that they're aware of. For now, I'll leave this as a draft. |
markbackman
force-pushed
the
mb/rime-websocket
branch
from
ac7e7b8 to
97586b1
Compare
| self._started = False | ||
| self._context_id = None | ||
|
|
||
| def _calculate_word_times(self, words: list, starts: list, ends: list) -> list: |
There was a problem hiding this comment.
It feels like the ends list is included as a function argument, but it is never actually used in the function logic. Do we need it here ?
There was a problem hiding this comment.
We do need to pass ends for the zip iteration, but don't need it in the loop. So, I'm updating to make that clear.
Codecov ReportAttention: Patch coverage is
|
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
In progress. Waiting to resolve a few things related to word/timestamp alignment.