-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add selector handling in k8s plugin sync and rollback stage #5577
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5577 +/- ##
==========================================
- Coverage 26.33% 26.30% -0.04%
==========================================
Files 467 469 +2
Lines 50114 50186 +72
==========================================
+ Hits 13198 13199 +1
- Misses 35860 35930 +70
- Partials 1056 1057 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What this PR does:
This PR partially resolves TODO in K8S_SYNC and K8S_ROLLBACK implementation of the Kubernetes plugin.
Why we need it:
To make the k8s plugin behave the same as the current piped's Kubernetes deployment feature.
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: