Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selector handling in k8s plugin sync and rollback stage #5577

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Feb 17, 2025

What this PR does:

This PR partially resolves TODO in K8S_SYNC and K8S_ROLLBACK implementation of the Kubernetes plugin.

Why we need it:

To make the k8s plugin behave the same as the current piped's Kubernetes deployment feature.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 24.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 26.30%. Comparing base (14f3d0b) to head (e84c32f).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
...p/pipedv1/plugin/kubernetes/deployment/rollback.go 0.00% 9 Missing ⚠️
...g/app/pipedv1/plugin/kubernetes/deployment/sync.go 12.50% 6 Missing and 1 partial ⚠️
...g/app/pipedv1/plugin/kubernetes/deployment/misc.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5577      +/-   ##
==========================================
- Coverage   26.33%   26.30%   -0.04%     
==========================================
  Files         467      469       +2     
  Lines       50114    50186      +72     
==========================================
+ Hits        13198    13199       +1     
- Misses      35860    35930      +70     
- Partials     1056     1057       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi marked this pull request as ready for review February 17, 2025 08:00
Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Warashi Warashi enabled auto-merge (squash) February 19, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants