Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the current migration process for the plugin architecture #5368

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Nov 27, 2024

What this PR does:

Clarify the current migration process idea for the plugin architecture.

Why we need it:

We want to consider the migration cost as less as possible.

Which issue(s) this PR fixes:

Part of #5252

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's clearer, thank you.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.57%. Comparing base (90b5d07) to head (aabd6d6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5368      +/-   ##
==========================================
- Coverage   25.57%   25.57%   -0.01%     
==========================================
  Files         447      447              
  Lines       48004    48004              
==========================================
- Hits        12279    12277       -2     
- Misses      34765    34768       +3     
+ Partials      960      959       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-kikuc t-kikuc enabled auto-merge (squash) November 27, 2024 01:49
@t-kikuc t-kikuc changed the title Clarify current the migration process for the plugin architecture Clarify the current migration process for the plugin architecture Nov 27, 2024
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-kikuc t-kikuc merged commit fd8dc17 into master Nov 27, 2024
18 checks passed
@t-kikuc t-kikuc deleted the modify-rfc-for-plugin-architecture branch November 27, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants