Add detail spec for platform provider and kind in the plugin architecture #5357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
ffjlabo
requested review from
nghialv,
khanhtc1202,
kentakozuka,
t-kikuc and
Warashi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5357 +/- ##
=======================================
Coverage 25.41% 25.41%
=======================================
Files 445 446 +1
Lines 47793 47807 +14
=======================================
+ Hits 12146 12150 +4
- Misses 34697 34708 +11
+ Partials 950 949 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Warashi
reviewed
Nov 21, 2024
Comment on lines
170
to
194
| ```golang | ||
| func (a * Application) GetKind() string { | ||
| // First, check the application is supported by the plugin architecture. It means that the kind is set to "Application". | ||
| // If so, return the kind from the labels. | ||
| if a.Kind == ApplicationKind_Application { | ||
| return a.Labels["kind"] | ||
| } | ||
|
|
||
| // For backward compatibility, return the kind as string | ||
| return a.Kind.String() | ||
| } | ||
| ``` | ||
|
|
||
| ```golang | ||
| func (d *Deployment) GetKind() string { | ||
| // First, check the application is supported by the plugin architecture. It means that the kind is set to "Application". | ||
| // If so, return the kind from the labels. | ||
| if d.Kind == ApplicationKind_Application { | ||
| return d.Labels["kind"] | ||
| } | ||
|
|
||
| // For backward compatibility, return the kind as string | ||
| return d.Kind.String() | ||
| } | ||
| ``` |
There was a problem hiding this comment.
[nits] These snippets seem duplicated.
Signed-off-by: Yoshiki Fujikane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Defined to use the
DeployTargetinstead ofPlatform Provider, andlabels["kind"]instead ofKindin the plugin architecture.Why we need it:
We plan to introduce the alternatives for
PlatformProviderandKind: K8sApp, ECSApp, ...(existing kind) in the plugin architecture.But we should consider the backward compatibility. So I wrote how to do that in the rfc.
Which issue(s) this PR fixes:
Part of #5252
Does this PR introduce a user-facing change?: