Skip to content

new option #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 365 commits into
base: var_dump
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
365 commits
Select commit Hold shift + click to select a range
9fd045b
Merge pull request #67 from peter-gribanov/BetterJSAlternative_di
Sep 5, 2017
f59bb51
Merge pull request #65 from alexislefebvre/patch-1
Sep 5, 2017
45b698a
Merge pull request #62 from webaholik/patch-1
Sep 5, 2017
7822f53
Merge branch 'master' into isp
peter-gribanov Sep 5, 2017
83146a7
Merge pull request #42 from peter-gribanov/isp
Sep 5, 2017
2a9cef3
remove invalid comment
peter-gribanov Sep 5, 2017
6f59430
rename classes and interface
peter-gribanov Sep 5, 2017
3652f83
Merge pull request #43 from peter-gribanov/dip
Sep 5, 2017
e1d22a8
Update README.md
php-cpm Sep 6, 2017
b9d4c30
Update README.md
php-cpm Sep 6, 2017
52fa4b6
Merge pull request #64 from php-cpm/patch-1
Sep 6, 2017
b82c80d
Correct CS in objects
emnsen Sep 6, 2017
9f1be53
Different function name used in the example.
amitmerchant1990 Sep 6, 2017
4da91b5
Fixed a typo
amitmerchant1990 Sep 6, 2017
97381f5
Fixed more typos.
amitmerchant1990 Sep 6, 2017
cbfad21
use json const
peter-gribanov Sep 6, 2017
e507f54
add user access example
peter-gribanov Sep 6, 2017
51e0234
rename const ACCESS_ALL to ACCESS_FULL
peter-gribanov Sep 6, 2017
4a1cdae
use my serializer. not a PHP function serialize()
peter-gribanov Sep 6, 2017
05e0bbc
Not use bitwise offset. It's too complicated
peter-gribanov Sep 6, 2017
4b4808c
spelling correction
matanshavit Sep 6, 2017
412343a
Merge pull request #79 from amitmerchant1990/patch-2
Sep 6, 2017
d9db490
Merge pull request #82 from matannoam/patch-1
Sep 6, 2017
efebe35
Merge pull request #77 from emnsen/patch-1
Sep 6, 2017
7ec6881
README: make human headline
Sep 6, 2017
f9e463a
Update README.md
amitmerchant1990 Sep 7, 2017
3e3bac6
leave only CRUD access
peter-gribanov Sep 7, 2017
a5de98d
Upgrade of a GOOD example for section "Avoid conditionals"
Sep 7, 2017
6c01399
Merge pull request #5 from jupeter/master
peter-gribanov Sep 7, 2017
0de08e1
change preg_split() to explode()
peter-gribanov Sep 7, 2017
9f0fec6
Fix minor typo in Interface Segregation Principle
DaxServer Sep 7, 2017
e9c915b
function split() is DEPRECATED
peter-gribanov Sep 7, 2017
bff562b
correct text and code style
peter-gribanov Sep 7, 2017
6a2a5ac
Merge pull request #78 from amitmerchant1990/patch-1
Sep 7, 2017
28868ba
Merge pull request #80 from peter-gribanov/searchable_names_2
Sep 7, 2017
019b619
Merge pull request #86 from FelipeeDev/master
Sep 7, 2017
924d96a
Merge branch 'master' into cs
peter-gribanov Sep 7, 2017
51f6769
expand description of Singleton
peter-gribanov Sep 7, 2017
5bc8682
correct link to Coupling
peter-gribanov Sep 7, 2017
9d547ab
change vocabulary example #92
peter-gribanov Sep 7, 2017
179cc13
add thoughts by Misko Hevery
peter-gribanov Sep 7, 2017
5e52aa3
not use config.php file
peter-gribanov Sep 8, 2017
528af36
Merge pull request #97 from peter-gribanov/global_functions
Sep 8, 2017
f508d3c
Merge pull request #93 from peter-gribanov/vocabulary
Sep 8, 2017
53a944d
Merge pull request #89 from peter-gribanov/split
Sep 8, 2017
2b15b6f
Merge branch 'master' into cs
Sep 8, 2017
cd7733d
remove redundant spaces
Sep 8, 2017
8979cdc
Merge pull request #90 from peter-gribanov/cs
Sep 8, 2017
cdbe01b
Merge pull request #88 from SrihariThalla/typo-fix
Sep 8, 2017
7624697
Merge pull request #87 from peter-gribanov/preg_split
Sep 8, 2017
1f8bf0a
Merge branch 'master' into singleton_desc
peter-gribanov Sep 9, 2017
780af00
identified important parts
peter-gribanov Sep 9, 2017
d7ddc1d
Merge pull request #91 from peter-gribanov/singleton_desc
Sep 9, 2017
a10956b
Avoid nesting too deeply and return early
jewei Sep 10, 2017
2ba9929
correct good example
peter-gribanov Sep 11, 2017
e7c2515
fix typo
peter-gribanov Sep 11, 2017
99da63b
Merge pull request #7 from jupeter/master
peter-gribanov Sep 11, 2017
39ca3ce
Merge branch 'master' into lsp3
peter-gribanov Sep 11, 2017
5383a97
add links to every sections in table of contents
peter-gribanov Sep 11, 2017
4a5cedb
correct link
peter-gribanov Sep 11, 2017
1e615be
move out SOLID section
peter-gribanov Sep 11, 2017
23e6a5c
add description for SOLID
peter-gribanov Sep 11, 2017
34eb8da
Merge pull request #102 from peter-gribanov/table_of_contents
Sep 11, 2017
51202bb
Merge pull request #8 from jupeter/master
peter-gribanov Sep 11, 2017
186ec4f
Merge branch 'solid' into master
peter-gribanov Sep 11, 2017
6f659f4
Merge pull request #9 from peter-gribanov/master
peter-gribanov Sep 11, 2017
6051bd5
Better code examples
jewei Sep 11, 2017
33ebd80
Merge pull request #100 from jewei/master
Sep 11, 2017
68c69e7
Merge pull request #103 from peter-gribanov/solid
Sep 11, 2017
ccd52d7
Merge pull request #10 from jupeter/master
peter-gribanov Sep 11, 2017
a09df2c
add links to table of contents
peter-gribanov Sep 11, 2017
21828c7
correct links
peter-gribanov Sep 11, 2017
924c563
Remove bad eaxample
peter-gribanov Sep 12, 2017
ab07e05
use PHP 5.6 pow()
peter-gribanov Sep 12, 2017
8a64dfc
change the title of encapsulation section
peter-gribanov Sep 12, 2017
acf92a1
Proposal to fix issue #37
mcustiel Sep 12, 2017
0d94f33
Update README.md
mcustiel Sep 12, 2017
c2af508
fix typo
peter-gribanov Sep 12, 2017
563028b
Moved `Use method chaining` to `Avoid fluent interfaces`
Slamdunk Sep 13, 2017
62e82fc
Merge pull request #81 from Slamdunk/patch-1
Sep 13, 2017
98351e4
Add travis checks for spaces and table of contents
Slamdunk Sep 13, 2017
26bc22c
Merge pull request #107 from Slamdunk/travis
Sep 13, 2017
5bd7755
Merge pull request #11 from jupeter/master
peter-gribanov Sep 13, 2017
3e20417
Merge pull request #105 from peter-gribanov/encapsulation
Sep 14, 2017
b2dd441
add info text for private/protected members
peter-gribanov Sep 14, 2017
1993924
add type hinting
peter-gribanov Sep 14, 2017
bcc9eaf
return self in Car fluent interfaces
peter-gribanov Sep 14, 2017
2d6197a
Merge pull request #12 from jupeter/master
peter-gribanov Sep 14, 2017
ed8ccff
Merge pull request #110 from peter-gribanov/php7
Sep 15, 2017
196837f
Merge branch 'master' into lsp3
peter-gribanov Sep 15, 2017
429d584
Minor grammatical fixes
okj579 Sep 15, 2017
0645c50
Merge pull request #13 from jupeter/master
peter-gribanov Sep 15, 2017
d6c0ddb
add Russian translation
peter-gribanov Sep 15, 2017
6261d51
add Thai language
peter-gribanov Sep 15, 2017
d883307
add Portuguese language
peter-gribanov Sep 15, 2017
f4724b6
use emoji
peter-gribanov Sep 15, 2017
e11b2ce
add more translations
peter-gribanov Sep 15, 2017
e394cbe
Merge pull request #114 from peter-gribanov/add_ru
Sep 15, 2017
cfc058e
change description of private/protected
peter-gribanov Sep 15, 2017
bc8c10d
Merge pull request #104 from peter-gribanov/avoid_nesting
Sep 15, 2017
278a45a
Merge pull request #113 from okj579/patch-1
Sep 15, 2017
0b06120
fix mistakes
peter-gribanov Sep 15, 2017
4386410
Merge pull request #109 from peter-gribanov/private_protected
Sep 16, 2017
f2563f8
Merge pull request #15 from jupeter/master
peter-gribanov Sep 18, 2017
a26b56a
remove out of date chinese translations
peter-gribanov Sep 18, 2017
0b6ab70
add Spanish translation
peter-gribanov Sep 18, 2017
51b4b87
Optimize conditions in 'Avoid nesting too deeply and return early (pa…
yuriyzinchenko Sep 18, 2017
0e13574
Merge pull request #115 from peter-gribanov/trans
Sep 18, 2017
998dd02
Merge pull request #116 from yuriyzinchenko/avoid_nesting2
Sep 18, 2017
b488cc2
fix example in LSP section
yuriyzinchenko Sep 18, 2017
4df90de
use true for trick types. Check http://php.net/manual/en/function.in-…
AlaaAttyaMohamed Sep 20, 2017
664bfe0
Merge pull request #17 from jupeter/master
peter-gribanov Sep 22, 2017
f213dfd
version announce
peter-gribanov Sep 22, 2017
8fc58f6
Merge pull request #121 from peter-gribanov/version_announce
Sep 22, 2017
62fc6bd
Merge pull request #118 from AlaaAttya/master
Sep 22, 2017
1cf35d4
Update README.md
ZielinskiLukasz Sep 23, 2017
3239445
fix typo
peter-gribanov Sep 25, 2017
e9b19fc
Merge pull request #123 from peter-gribanov/version_announce
Sep 25, 2017
72896e0
Merge pull request #122 from ZielinskiLukasz/master
Sep 27, 2017
091009e
add Rectangle[] typehints
Sep 27, 2017
3309c09
Merge pull request #117 from yuriyzinchenko/fix_lsp
Sep 27, 2017
b269833
Merge pull request #18 from jupeter/master
peter-gribanov Sep 27, 2017
c59276d
Merge branch 'master' into lsp3
peter-gribanov Sep 27, 2017
0eb9d04
zipCode is required
peter-gribanov Sep 28, 2017
dc125f0
optimize cityZipCodeRegex
peter-gribanov Sep 28, 2017
2d8720c
Merge pull request #125 from peter-gribanov/cityZipCodeRegex
Oct 1, 2017
40ca2e5
rename methods in BankAccount
peter-gribanov Oct 6, 2017
42fcf8c
Made changes suggested in code review
mcustiel Oct 6, 2017
27103f4
Rename get balance method
peter-gribanov Oct 7, 2017
2e03a76
yoda condition and identical comparison added
ismail1432 Oct 7, 2017
006f2c4
Merge pull request #127 from peter-gribanov/balance
Oct 7, 2017
5be3c23
Merge pull request #20 from jupeter/master
peter-gribanov Oct 23, 2017
348809d
remove yoda condition and keep identical comparison
ismail1432 Oct 23, 2017
588a2e1
more details about identical comparison
ismail1432 Oct 23, 2017
79eabee
Add french translation
Errorname Nov 26, 2017
409b5ce
Merge pull request #133 from ErrOrnAmE/patch-1
Nov 26, 2017
1456a97
add prifix for getters
peter-gribanov Nov 27, 2017
68a0003
remove Not bad section
peter-gribanov Nov 27, 2017
9ba90de
Merge pull request #23 from jupeter/master
peter-gribanov Nov 30, 2017
d807a24
Fix Php version for type hinting
DylanDelobel Dec 21, 2017
1b4a2a1
Fix const color miss match
hoseinz3 Dec 28, 2017
0662992
Add peter-gribanov suggestion
DylanDelobel Dec 29, 2017
0344eab
Merge pull request #134 from DylanDelobel/master
Dec 29, 2017
935db2c
Merge pull request #136 from hoseinz3/master
Dec 29, 2017
77c0a5b
Merge pull request #128 from ismail1432/master
Dec 29, 2017
25696c0
Merge branch 'master' into master
Dec 29, 2017
b133b4f
Merge branch 'master' into master
Dec 29, 2017
c72d413
Merge pull request #106 from mcustiel/master
Dec 29, 2017
f3f0724
Merge remote-tracking branch 'jupeter/master'
peter-gribanov Jan 9, 2018
7909ca8
format Comparison section
peter-gribanov Jan 9, 2018
1f00bc8
Merge branch 'master' into lsp3
peter-gribanov Jan 9, 2018
858d5f1
Update README.md
henryonsoftware Jan 15, 2018
aa7a7eb
Update README.md
henryonsoftware Jan 15, 2018
3b30f1e
Fixed a link in the menu (Comparison)
bkosun Jan 29, 2018
6ca5138
Fixed a link in the menu (Use identical compar...)
bkosun Jan 29, 2018
46a3882
fixed some typos and inconsistencies
michaelmillar Jan 29, 2018
e90be29
Wording adjustment
jopacicdev Feb 16, 2018
66bcb6a
final keyword
Spomky Feb 23, 2018
e191bf8
Typo
Spomky Feb 23, 2018
88c7865
Typo
Spomky Feb 23, 2018
9ae7bbf
add Korean translation
Feb 25, 2018
9a7c33a
Merge pull request #145 from yujineeee/patch-1
Feb 26, 2018
48af26a
Merge pull request #143 from jopacicdev/patch-1
Feb 26, 2018
ab11164
Merge pull request #142 from mwmichael/typos
Feb 26, 2018
2712c5b
Merge branch 'master' into master
Feb 26, 2018
43629e6
Merge pull request #141 from knbv/master
Feb 26, 2018
53c7dad
Merge branch 'master' into patch-1
Feb 26, 2018
03ecd69
Merge pull request #140 from viethuongdev/patch-1
Feb 26, 2018
c537087
Merge branch 'master' into comparison
peter-gribanov Feb 26, 2018
a1ac1b0
Merge pull request #139 from peter-gribanov/comparison
Feb 26, 2018
5492fa0
Merge pull request #25 from jupeter/master
peter-gribanov Feb 26, 2018
dfe3d11
use github emoji code for flags of translations
peter-gribanov Feb 26, 2018
03ef357
Merge pull request from peter-gribanov/master
peter-gribanov Feb 26, 2018
6c1da67
remove not used getters
peter-gribanov Feb 26, 2018
b19b3a1
Merge pull request #101 from peter-gribanov/lsp3
Feb 26, 2018
cde476e
Merge pull request #146 from peter-gribanov/translations_icon
Feb 27, 2018
ab83eec
Reference to Ocramius blog post added
Spomky Feb 27, 2018
583523f
Merge pull request #144 from Spomky/final
Feb 27, 2018
39d511f
rename classes to avoid confusion
peter-gribanov Apr 10, 2018
bb07edb
Merge pull request #148 from peter-gribanov/isp
TomasVotruba Aug 21, 2018
15bc7a3
Add Turkish Translation
Sep 14, 2018
55b6a19
Merge pull request #154 from jupeter/turkish
TomasVotruba Sep 16, 2018
7a7a1f0
used a better name for Vehicle abstraction
Oct 5, 2018
810f537
Merge remote-tracking branch 'jupeter/master'
peter-gribanov Jan 29, 2019
6be37a0
add default value for User::$access
peter-gribanov Jan 29, 2019
f080c5b
add deny access rights example
peter-gribanov Jan 29, 2019
acb8ba0
Fixed - opposite for condition
grogy May 12, 2019
49be90a
Merge pull request #163 from grogy/patch-1
TomasVotruba Jun 19, 2019
bb000f6
Merge pull request #162 from peter-gribanov/binary_and
TomasVotruba Jun 19, 2019
56c67dd
Merge pull request #155 from domnikl/avoid-type-checking-part-1-naming
TomasVotruba Jun 19, 2019
e0fc6a8
allow use more of the two depth levels in table of contents
peter-gribanov Jul 11, 2019
9222ff3
allow use unicode in link names
peter-gribanov Jul 11, 2019
4022b02
ignore links in title
peter-gribanov Jul 11, 2019
d29db02
not use quotes in table of contents
peter-gribanov Jul 11, 2019
7a37fdf
remove space character at end of lines
peter-gribanov Jul 11, 2019
f9d66a2
rename function parseBetterJSAlternative() -> parseBetterPHPAlternati…
peter-gribanov Jul 11, 2019
eb31d2d
use VO in example of "Function arguments (2 or fewer ideally)"
peter-gribanov Jul 23, 2019
4f11e53
add getters comment
peter-gribanov Jul 23, 2019
5969ca9
not set default values of string VO properties
peter-gribanov Jul 26, 2019
c3ba178
Merge pull request #168 from peter-gribanov/fun_args_3
TomasVotruba Sep 12, 2019
e73bc83
Merge pull request #166 from peter-gribanov/js_to_php
TomasVotruba Sep 12, 2019
dfed2b1
Merge pull request #165 from peter-gribanov/fix_text_style
TomasVotruba Sep 18, 2019
89ab6f1
Merge pull request #164 from peter-gribanov/tests
TomasVotruba Sep 18, 2019
5e2d423
delete "Functions should do one thing" section
peter-gribanov Sep 18, 2019
8693a08
Merge pull request #170 from peter-gribanov/delete_functions_one_thing
TomasVotruba Sep 18, 2019
8f327f8
Add "public" to const declarations
bu4ak Oct 2, 2019
062b4e2
Merge pull request #171 from Bu4ak/access-modifier-constant-fix
TomasVotruba Oct 5, 2019
390ff76
Update Prefer composition over inheritance
Mar 11, 2020
c6599cb
Merge pull request #1 from Shpartko/Shpartko-patch-1
Mar 11, 2020
8f6c4ee
Change example to null coalescing
leocarmo Apr 9, 2020
2a33156
Add null coalescing section
leocarmo Apr 9, 2020
1121a80
Merge pull request #174 from php-rock/master
TomasVotruba Jun 23, 2020
b215860
Merge pull request #175 from leocarmo/null-coalescing
TomasVotruba Jun 23, 2020
2c94c03
[ci] switch travis dummy cs check, to Github Actions and ECS with mar…
TomasVotruba Oct 28, 2020
d60f4a6
apply coding standard on README
TomasVotruba Oct 28, 2020
9df6c17
workflow: update php
TomasVotruba Oct 28, 2020
43dfecd
restore required mallforms
TomasVotruba Oct 28, 2020
13ab89d
Merge pull request #181 from jupeter/readme-cs
TomasVotruba Oct 28, 2020
c4bdcb6
add link to persian translation
peter-gribanov Jan 15, 2021
3218b7e
Misc spelling and grammar touch ups
diegoe Feb 6, 2021
0d47831
Remove declare strict_types from code snippets
andyexeter Apr 15, 2021
5467c3a
Merge pull request #188 from andyexeter/remove-declare-strict-types
TomasVotruba Apr 15, 2021
8572f4c
move "Use default arguments instead of short circuiting or conditiona…
peter-gribanov Apr 28, 2021
b12e986
fix typo
celyes May 25, 2021
c6808b9
fix link issue
celyes May 25, 2021
798fdd9
Merge pull request #191 from celyes/master
TomasVotruba May 26, 2021
7d4f52b
Merge pull request #190 from peter-gribanov/default_arguments
TomasVotruba May 26, 2021
1356e6d
Merge branch 'master' into diegoe_misc-typos
TomasVotruba May 26, 2021
a0ce001
Merge pull request #187 from diegoe/diegoe_misc-typos
TomasVotruba May 26, 2021
9ed47fe
Merge pull request #186 from peter-gribanov/persian_translation
TomasVotruba May 26, 2021
0374baa
update ECS and composer.json, allow PHP 7.2+
TomasVotruba May 26, 2021
9fab86d
[CI] run on push too
TomasVotruba May 26, 2021
c829a21
Add link to Bengali translation
nayeemdev Oct 15, 2021
ab6e4f2
Merge pull request #193 from nayeemdev/bengali_translation
TomasVotruba Oct 16, 2021
c46dfa4
Add colon after Vietnamese translation
ispopov Nov 17, 2021
95b23a0
Merge pull request #195 from ispopov/fix-punctuation
TomasVotruba Nov 17, 2021
51ed366
Rename pattern to principle
ispopov Nov 25, 2021
2b002eb
Merge pull request #196 from ispopov/fix-srp
TomasVotruba Nov 25, 2021
6e672f6
add arabic translation
Nov 27, 2021
f3d3e9f
Merge pull request #197 from AhmedJoda/master
TomasVotruba Nov 27, 2021
cb43aa2
add japanese translation
hayato07 Feb 11, 2022
89d7be7
Merge pull request #198 from hayato07/original
TomasVotruba Feb 11, 2022
8595ff5
change type hint url
ispopov May 18, 2022
5397e74
Merge pull request #200 from ispopov/fix-url
TomasVotruba May 19, 2022
fe8d53b
change type hinting url
ispopov May 19, 2022
8a8e4d9
Merge pull request #201 from ispopov/fix-url
TomasVotruba May 19, 2022
ca4ab1f
update Arabic translation username
ahmedalmory Jun 16, 2022
46fea97
Merge pull request #203 from ahmedalmory/patch-1
TomasVotruba Jun 16, 2022
eedf6c6
Fix wording in Comparison
szepeviktor Jun 19, 2022
8d90132
Merge pull request #204 from szepeviktor/patch-1
TomasVotruba Jun 19, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/coding_standard.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Coding Standard

on:
pull_request: null
push: null

jobs:
coding_standard:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
# see https://github.com/shivammathur/setup-php
- uses: shivammathur/setup-php@v2
with:
php-version: 8.0
coverage: none

- run: composer install --no-progress --ansi

- run: vendor/bin/ecs check-markdown README.md --ansi
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
composer.lock
/vendor
Loading