refactor(un-jsx): remove array inlining

pionxzh · May 7, 2024 · 6726af4 · 6726af4
1 parent bd0d74f
commit 6726af4
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 59 deletions.
diff --git a/packages/unminify/src/transformations/__tests__/un-jsx.spec.ts b/packages/unminify/src/transformations/__tests__/un-jsx.spec.ts
@@ -299,48 +299,6 @@ function fn() {
 `,
 )
 
-inlineTest('jsx with dynamic Component tag - tag name in an array',
-  `
-function fn() {
-  const components = ["div", "a"]
-  return React.createElement(
-    components[0],
-    null,
-    "Hello",
-  );
-}
-`,
-  `
-function fn() {
-  return <div>Hello</div>;
-}
-`,
-)
-
-inlineTest('jsx with dynamic Component tag - tag name in an array #invalid',
-  `
-function fn() {
-  const components = ["div", "a"]
-  return React.createElement(
-    components[3],
-    null,
-    "Hello",
-  );
-}
-`,
-  `
-function fn() {
-  const components = ["div", "a"]
-  const Component = components[3];
-  return React.createElement(
-    Component,
-    null,
-    "Hello",
-  );
-}
-`,
-)
-
 inlineTest('jsx with child text that should be wrapped',
   `
 function fn() {

diff --git a/packages/unminify/src/transformations/un-jsx.ts b/packages/unminify/src/transformations/un-jsx.ts
@@ -154,23 +154,6 @@ function toJSX(j: JSCodeshift, path: ASTPath<CallExpression>, pragmas: string[],
         tag = j.jsxIdentifier(name)
 
         const variableDeclaration = j.variableDeclaration('const', [j.variableDeclarator(j.identifier(name), type)])
-
-        // if variable has array
-        const isVariableDeclarationArray = root.find(j.VariableDeclarator, {
-            id: {
-                type: 'Identifier',
-                name: variableDeclaration.declarations[0].init?.object?.name,
-            },
-        })
-
-        if (isVariableDeclarationArray.length) {
-            isVariableDeclarationArray.forEach((path: any) => {
-                removeDeclarationIfUnused(j, path, path.node.id.name)
-                // this will pick value against index
-                tag = { ...tag, name: path.node.init.elements[variableDeclaration.declarations[0].init.property.value].value }
-            })
-        }
-
         const isVariableDeclaration = root.find(j.VariableDeclarator, {
             id: {
                 type: 'Identifier',