Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment savefile version to v91 #6010

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Conversation

sturnclaw
Copy link
Member

Addressed outstanding savebump tasks, including updating the NameGen en culture lists with contributor names.

Note that the name update is a best-effort only, and includes contributor surnames that could reasonably be considered American/British English derived.

A further pass on contributor names (and binning them to additional cultural lists as required) is a task for another PR by another author.

In total, 27 additional surnames were added to the name generation pool.

- Remove std::isnan() check in DynamicBody.cpp.
- Shields only serializes data into the provided JSON object and doesn't create its own subobject.
- Only english-seeming surnames updated at current; adds 27 additional surnames.
@sturnclaw sturnclaw requested a review from impaktor January 9, 2025 06:33
@sturnclaw sturnclaw merged commit 2b9846f into pioneerspacesim:master Jan 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant