Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible deadlock due to missing mutex unlock #3006

Closed
wants to merge 1 commit into from

Conversation

pabloFuente
Copy link
Contributor

Caused by a regression introduced in commit 835ac3b#diff-b8da7f3e746d55a2fe2a4295ae5fe5cf76b9512d7665201285143e25ab3bd3b9L423

Reference issue

Fixes #3005

@pabloFuente pabloFuente changed the title Fix possible deadlock dut to missing mutex unlock in datachannel.go Fix possible deadlock due to missing mutex unlock in datachannel.go Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.92%. Comparing base (49b555b) to head (778cbbd).

Files with missing lines Patch % Lines
datachannel.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3006      +/-   ##
==========================================
- Coverage   77.96%   77.92%   -0.05%     
==========================================
  Files          89       89              
  Lines       10578    10580       +2     
==========================================
- Hits         8247     8244       -3     
- Misses       1840     1844       +4     
- Partials      491      492       +1     
Flag Coverage Δ
go 79.48% <0.00%> (-0.05%) ⬇️
wasm 63.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cnderrauber cnderrauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@pabloFuente pabloFuente changed the title Fix possible deadlock due to missing mutex unlock in datachannel.go Fix possible deadlock due to missing mutex unlock Jan 16, 2025
@pabloFuente
Copy link
Contributor Author

I see that 2 checks have failed (commit message larger than 50 chars, and test coverage required for the new 2 lines).
Let me close this PR and prepare a new one fulfilling these requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Possible deadlock in DataChannel#DetachWithDeadline()
2 participants