Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for numpy 2 compatibility #1531

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Updates for numpy 2 compatibility #1531

merged 3 commits into from
Jul 8, 2024

Conversation

MichaelClerx
Copy link
Member

@MichaelClerx MichaelClerx commented Jun 17, 2024

  1. Not many changes in PINTS luckily, just replacing a np.array(x, copy=False) with np.asarray(x)
  2. Remaining errors are in pycma. These are already fixed in development but we'll need to wait for a new release.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3f2f153) to head (f5f1a37).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1531   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           97        97           
  Lines         9693      9693           
=========================================
  Hits          9693      9693           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelClerx
Copy link
Member Author

Fixes #1530

@MichaelClerx
Copy link
Member Author

The cma issue is also what's breaking the notebook tests right now

@nikohansen
Copy link

nikohansen commented Jul 5, 2024

I just released the latest pycma 3.4.0 which is compatible with numpy 2.0.

@MichaelClerx
Copy link
Member Author

Thanks @nikohansen !

@MichaelClerx
Copy link
Member Author

MichaelClerx commented Jul 8, 2024

In the meantime, a scipy update remove cumtrapz which had been deprecated, so fixed that too. It means the test that used this function now requires scipy 1.12, released Jan 2024 Updated it to work with old and new.

Copy link
Member

@chonlei chonlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Michael!

@MichaelClerx MichaelClerx merged commit a4fc16e into main Jul 8, 2024
13 checks passed
@MichaelClerx MichaelClerx deleted the numpy-2 branch July 8, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants