Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added value-based test for gradient descent. #1521

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

MichaelClerx
Copy link
Member

Should have done this in the first place 🙈

@MichaelClerx MichaelClerx requested a review from a team March 19, 2024 20:42
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (13b263a) to head (ce7abf9).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1521   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           97        97           
  Lines         9577      9577           
=========================================
  Hits          9577      9577           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@FarmHJ FarmHJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks good to me.

@MichaelClerx MichaelClerx merged commit abcc8e5 into main Mar 21, 2024
13 checks passed
@MichaelClerx MichaelClerx deleted the grad-desc-unit-test branch March 21, 2024 16:07
@MichaelClerx
Copy link
Member Author

Thanks @FarmHJ !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants