Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url params getting changed erroneously #1726

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

bhnord
Copy link
Contributor

@bhnord bhnord commented Oct 4, 2024

Bugs:

  • URL params were getting changed: a param like ?param was getting changed to ?param= due to use in a javascript URLSearchParams object in env_tabs.tmpl.
  • Some pages were not getting fed the correct data to render stage type filter.
  • Some pages were rendering env_tabs but not providing the correct data to render the tabs
  • Deploy history page was checking all rendered components and putting a limit on checked checkboxes, interfering with stage type filter

Fixes

  • URL params are now modified with a custom parser in env_tabs.tmpl to not change url params formatting.
  • Necessary pages are now fed correct data to render stage type filter.
  • Pages that were previously rendering env_tabs.tmpl and not actually displaying any tabs (not providing the correct data) had the reference to env_tabs.tmpl removed.
  • Changed deploy history page to only check components inside deploy history table

@bhnord bhnord requested a review from a team as a code owner October 4, 2024 16:05
@github-actions github-actions bot added the deploy-board Includes changes to deploy-board label Oct 4, 2024
@bhnord bhnord merged commit 0903df2 into master Oct 4, 2024
6 checks passed
@bhnord bhnord deleted the bnordemann/fix-stages-filter branch October 4, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-board Includes changes to deploy-board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants