Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the script configuration variable DISABLE_BACKUP_INSTANCE_TYPES to control whether backup instance types are enabled or disabled #1712

Merged
merged 8 commits into from
Sep 11, 2024

Conversation

liyaqin1
Copy link
Contributor

@liyaqin1 liyaqin1 commented Sep 6, 2024

Additional improvements are still needed before we can roll this feature out to the production instance.

@liyaqin1 liyaqin1 requested a review from a team as a code owner September 6, 2024 23:52
@github-actions github-actions bot added the deploy-board Includes changes to deploy-board label Sep 6, 2024
@liyaqin1
Copy link
Contributor Author

liyaqin1 commented Sep 7, 2024

I tested this on dev1. When the variable is set to true, the feature is hidden on the UI.
Screenshot 2024-09-06 at 5 12 49 PM
Screenshot 2024-09-06 at 5 14 09 PM

@liyaqin1
Copy link
Contributor Author

liyaqin1 commented Sep 7, 2024

If I remove the variable from the script config, the feature reappears on the UI.

Screenshot 2024-09-06 at 5 17 14 PM Screenshot 2024-09-06 at 5 18 26 PM

@liyaqin1
Copy link
Contributor Author

liyaqin1 commented Sep 7, 2024

Hi @osoriano , since there are still several improvements needed for the backup instance types feature, I don’t want to enable it on the production instance just yet. This PR allows us to disable the feature by setting a script configuration variable.
Additionally, I will be out of office next Monday and Tuesday. If anyone needs to deploy the Teletraan UI to the production instance, please ensure that Rodimus deploys the latest commit first, before deploying the Teletraan UI. Also, make sure that this PR is merged and deployed.
Thank you very much.
By the way, I have already added this script config variable for the production Teletraan UI.
Screenshot 2024-09-06 at 5 21 42 PM

@liyaqin1 liyaqin1 merged commit 01f03af into master Sep 11, 2024
6 checks passed
@liyaqin1 liyaqin1 deleted the yaqin/addFlag branch September 11, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-board Includes changes to deploy-board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants