Fix and improve group status metrics graphs and dashboard URLs #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osoriano
reviewed
Aug 14, 2024
osoriano
previously approved these changes
Aug 14, 2024
Co-authored-by: Omar <[email protected]>
osoriano
approved these changes
Aug 14, 2024
tylerwowen
added a commit
that referenced
this pull request
Aug 16, 2024
## Changes ## TAS Previously launch latency was emitted by a Rodimus worker. This PR implements the same measure in the TAS. Launch latency is defined as the duration from host launch to the the complete of the first deployment. It measures for all environments deployed on new hosts. The configuration **Launch grace period** is the user set threshold for this latency and it's used for AgentJanitor and Rodimus health check. Another fix is that I found all first deploy metrics were success. So I updated the condition when the `first_deploy` flag should be turned off. ## UI While updating the group status page to include the launch latency, I realized I forgot that the original plan was to create a dashboard. So I removed the links added in #1694, created a dashboard including the changes in a new Teletraan user dashboard. Fixed launch failure rate graph and updated some metrics calculations. <img width="1641" alt="image" src="https://github.com/user-attachments/assets/ef62bb3b-7748-4afa-b66a-f0a89111f8b6"> ## Test plan ### TAS 1. Deploy this PR to TAS dev1 2. Launch a new host in tyler/test - [x] Launch latency should be emitted - [x] First deploy counter should increment with success=true. 4. Deploy a bad build to tyler/test 5. Launch a new host - [x] Launch latency should be emitted - [x] First deploy counter should increment with success=false. ### UI 1. Deploy this PR to deploy-board dev1 2. Visit group status page /groups/tyler-test/ - [x] verify the link is updated and working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old links are broken, so build new statsboard graphs using new metrics and new APIs.
The old graphs are not referencing the right metrics, so updated the metrics source. Count -> Rate.
Note that statsboard links are preferred over rendered graphs, and thus they are moved above the graphs.
Group size
Provision Latency
Deploy Latency
Deploy success rate