Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U24 support for deploy-agent #1653

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Conversation

osoriano
Copy link
Contributor

Add support for Ubuntu 24 to deploy-agent. This includes adding
support for Python 3.12. Also, this drops support for Python 3.6

This requires updating some packages (e.g. requests, gevent, boto). For
boto, there was a migration to (boto3).

Testing done:

  • Unit tests passed
  • Installed the deploy-agent package on an Ubuntu 24 host
    • Deploy agent ran, but failed due to missing facter command
  • Installed the deploy-agent package on an Ubuntu 20 host
    • The deploy agent worked as expected. Was able to install new
      Teletraan builds and restart a Teletraan stage

@github-actions github-actions bot added the deploy-agent Includes changes to deploy-agent label Jun 27, 2024
Update build steps for py38 and py312.

This also drops support for py36
@osoriano osoriano force-pushed the deployd-u24-no-py36 branch 2 times, most recently from 976f1e1 to 019f986 Compare June 28, 2024 17:46
@osoriano osoriano marked this pull request as ready for review June 28, 2024 17:52
@osoriano osoriano requested a review from a team as a code owner June 28, 2024 17:52
Bump the dependencies to support py38 and py312.

Support for py36 is dropped
The `boto` dependency is no longer supported on py312. Switch to boto3
@gzpcho
Copy link
Contributor

gzpcho commented Jun 28, 2024

Deploy agent ran, but failed due to missing facter command

why is this? is facter available in ubuntu20 but not ubuntu24?

@osoriano
Copy link
Contributor Author

Deploy agent ran, but failed due to missing facter command

why is this? is facter available in ubuntu20 but not ubuntu24?

It was a barebones u24 host for testing

@osoriano osoriano merged commit f770014 into pinterest:master Jun 28, 2024
8 checks passed
@osoriano osoriano deleted the deployd-u24-no-py36 branch June 28, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-agent Includes changes to deploy-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants