Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added host protection status #1640

Merged
merged 11 commits into from
Jun 6, 2024
Merged

added host protection status #1640

merged 11 commits into from
Jun 6, 2024

Conversation

Cjpilbdev
Copy link
Contributor

@Cjpilbdev Cjpilbdev commented Jun 3, 2024 •
edited
Loading

image image image

@Cjpilbdev Cjpilbdev requested a review from a team as a code owner June 3, 2024 08:33
@github-actions github-actions bot added the deploy-board Includes changes to deploy-board label Jun 3, 2024
@Cjpilbdev Cjpilbdev added draft DO NOT MERGE do not merge the PR labels Jun 3, 2024
@knguyen100000010
Copy link
Contributor

Can you create a short Loom video to walk through the UI/display?

@knguyen100000010
Copy link
Contributor

Some format issue as reported by pre-commit job:
image

@osoriano
Copy link
Contributor

osoriano commented Jun 4, 2024

The lint error should be fixed. Can you rebase and retry?

@Cjpilbdev
added is protected
b36aa4f
@Cjpilbdev
fix style
e6f6e22
@Cjpilbdev
fix style
d81e7ef 
fix style

fix style

fix error url button protect host

add label

added label
@Cjpilbdev
added missing import
59c624b
@Cjpilbdev Cjpilbdev removed draft DO NOT MERGE do not merge the PR labels Jun 5, 2024
@Cjpilbdev
Copy link
Contributor Author

Can you create a short Loom video to walk through the UI/display?

https://www.loom.com/share/07e6259f927d42369ffd78a7b8181017

@Cjpilbdev Cjpilbdev merged commit e8397fd into master Jun 6, 2024
6 checks passed
@Cjpilbdev Cjpilbdev deleted the protect-hosts branch June 6, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knguyen100000010 knguyen100000010 knguyen100000010 approved these changes

@liyaqin1 liyaqin1 liyaqin1 approved these changes

Assignees
No one assigned
Labels
deploy-board Includes changes to deploy-board
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cjpilbdev @knguyen100000010 @osoriano @liyaqin1