update cmdb to support multi-account #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osoriano
reviewed
May 22, 2024
osoriano
previously approved these changes
May 22, 2024
osoriano
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CMDB API supports multi-account through a header. We should update all CMDB API calls to pass the aws owner id in requests to resources in accounts besides hostmaster.
Testing
Links to
<domain-name>/phobos/<host-ip>/instead of<domain-name>/env/for-test/rzhu-integ-moka-test/host/<host-name>for hosts outside main account.Regression Testing
host dist charts work for multi-accounts
