Ensure delivery_type / stage_type are in sync
#1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Enforce that the `delivery_type` (value passed in by deployment pipeline) needs to be in sync with the `stage_type`. If they are not in sync, throw an error so that users can take action and resolve the inconsistency. **Caveats** In case the `delivery_type` / `stage_type` is out of sync, this could cause deployment failures. These failures should not happen frequently and are currently expected to be resolved manually. **Test Plan** Verified there have been no inconsistencies in the last week.
liyaqin1
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enforce that the
delivery_type(value passed in by deployment pipeline) needs to be in sync with thestage_type.If they are not in sync, throw an error so that users can take action and resolve the inconsistency.
Caveats
In case the
delivery_type/stage_typeis out of sync, this could cause deployment failures.These failures should not happen frequently and are currently expected to be resolved manually.
Test Plan
Verified there have been no inconsistencies in the last week and a half.