Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deploy-agent] Return type hints in download folder #1403

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[deploy-agent] Return type hints in download folder #1403

merged 1 commit into from
Feb 1, 2024

Conversation

gzpcho
Copy link
Contributor

@gzpcho gzpcho commented Jan 17, 2024 •
edited
Loading

Improve readability for low risk:

The Python runtime does not enforce function and variable type annotations.

@gzpcho gzpcho requested a review from a team as a code owner January 17, 2024 17:03
@gzpcho gzpcho requested a review from ntascii January 17, 2024 18:54
ntascii
ntascii approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@ntascii ntascii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to release sequentially

@gzpcho gzpcho mentioned this pull request Jan 19, 2024
Closed
@gzpcho gzpcho merged commit 0349e3b into master Feb 1, 2024
6 checks passed
@gzpcho gzpcho deleted the iroquebert/return-type-hints-1 branch February 1, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntascii ntascii ntascii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gzpcho @ntascii