Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add drop down menu for showing main account and sub account #1240

Merged
merged 32 commits into from
Aug 25, 2023
Merged

add drop down menu for showing main account and sub account #1240

merged 32 commits into from
Aug 25, 2023

Conversation

liyaqin1
Copy link
Contributor

No description provided.

@liyaqin1 liyaqin1 requested a review from a team as a code owner August 23, 2023 20:12
@liyaqin1
Copy link
Contributor Author

Tested on dev1.
If I select Main Account, it shows the main account hosts; if I select Sub Account, it shows the sub account host which in this case means nothing.
Screenshot 2023-08-23 at 1 13 24 PM
Screenshot 2023-08-23 at 1 13 36 PM

ntascii
ntascii approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@ntascii ntascii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liyaqin1 liyaqin1 merged commit d7420ca into master Aug 25, 2023
4 checks passed
@liyaqin1 liyaqin1 deleted the yaqin/OptionForMainAccountAndSubAccount branch August 25, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntascii ntascii ntascii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liyaqin1 @ntascii