Update Health check alerts in Teletraan with Runbook info #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfleur01
changed the title
tylerwowen
reviewed
Jul 28, 2023
Comment on lines
+367
to
+369
| $("#runbooklinkExpressionId").click(function() { | ||
| $("#runbooklinkExpressionDetailsId").collapse('toggle'); | ||
| }); |
There was a problem hiding this comment.
non-blocking. This and all above can share the same class and this only need to apply to the class once.
tylerwowen
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is being submitted to provide a way for Teletraan operators to configure additional oncall information in the form of a runbook link for health check alerts.
Test Plan:
Create a health check that will eventually timeout
Confirm that the Email received is formatted correctly without the runbook link
Populate the Runbook Link in the UI
Confirm that the Link is populated in the UI and DB
Create a health check that will eventually timeout
Confirm that the Email received is formatted correctly without the runbook link