Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default auto update when there is a golden image for GA #1215

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Default auto update when there is a golden image for GA #1215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions deploy-board/deploy_board/templates/configs/new_capacity_adv.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,8 @@ <h4 class="panel-title pull-left">Capacity</h4>
baseImageHelpData: [],
baseImages: mapBaseImagesToOptions(baseImagesSorted),
baseImageValue: defaultImageId,
// Default to Pin image if there is a golden image before GA
// After GA, default to Auto Update.
pinImage: getPinImageValue(goldenImage, false),
// Default to Auto Update if there is a golden image.
pinImage: getPinImageValue(goldenImage, true),
pinImageEnabled: isPinImageEnabled(goldenImage),
configOptions: Object.keys(info.configList).map(
function (key) {
Expand Down Expand Up @@ -418,9 +417,8 @@ <h4 class="panel-title pull-left">Capacity</h4>
const defaultImageId = goldenImage ? goldenImage.id : getDefaultBaseImageId(baseImageSorted);
capacitySetting.baseImages = mapBaseImagesToOptions(baseImageSorted);
capacitySetting.baseImageValue = defaultImageId;
// Default not auto update if there is a golden image before GA
// Default auto update if there is a golden image after GA
capacitySetting.pinImage = getPinImageValue(goldenImage, false);
// Default auto update if there is a golden image
capacitySetting.pinImage = getPinImageValue(goldenImage, true);
capacitySetting.pinImageEnabled = isPinImageEnabled(goldenImage);
},
error: function (data) {
Expand Down