Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve health check display #1209

Merged
merged 4 commits into from
Jun 17, 2023
Merged

Improve health check display #1209

merged 4 commits into from
Jun 17, 2023

Conversation

liyaqin1
Copy link
Contributor

@liyaqin1 liyaqin1 commented Jun 16, 2023 •
edited
Loading

There are some problems on the health check ui:

  • It shows terminated when a host is still alive.
  • It shows green and qualified when the check is failed and the host is terminated.

@liyaqin1 liyaqin1 requested a review from a team as a code owner June 16, 2023 23:44
@liyaqin1
Copy link
Contributor Author

tested on integ, looks good:
Screenshot 2023-06-16 at 4 55 06 PM
Screenshot 2023-06-16 at 4 56 12 PM

@liyaqin1
Copy link
Contributor Author

if it is timeout, the ui look like :
Screenshot 2023-06-16 at 5 01 53 PM
Screenshot 2023-06-16 at 5 02 04 PM

@liyaqin1
Copy link
Contributor Author

if it is deployment failure, it look like:
Screenshot 2023-06-16 at 5 03 21 PM
Screenshot 2023-06-16 at 5 03 37 PM

@liyaqin1 liyaqin1 merged commit 1bcdf08 into master Jun 17, 2023
1 check passed
@liyaqin1 liyaqin1 deleted the yaqin/improveHealthCheckDisplay branch June 17, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerwowen tylerwowen tylerwowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liyaqin1 @tylerwowen