make sure there is running hosts when marking deploy state as succeeding

pinterest · Jul 27, 2024 · c50d2b2 · c50d2b2
1 parent d15f477
commit c50d2b2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/deploy-service/common/src/main/java/com/pinterest/deployservice/handler/CommonHandler.java b/deploy-service/common/src/main/java/com/pinterest/deployservice/handler/CommonHandler.java
@@ -312,7 +312,7 @@ void transition(DeployBean deployBean, DeployBean newDeployBean, EnvironBean env
         newDeployBean.setLast_update(System.currentTimeMillis());
 
         //The maximum sucThreshold is 10000 to keep precision.
-        if (succeeded * 10000 >= sucThreshold * total) {
+        if (succeeded * 10000 >= sucThreshold * total && succeeded > 0) {
             LOG.debug("Propose deploy {} as SUCCEEDING since {} agents are succeeded.", deployId, succeeded);
             if (deployBean.getSuc_date() == null) {
                 newDeployBean.setSuc_date(System.currentTimeMillis());