empty check

pinterest · Jul 26, 2023 · 9c1a848 · 9c1a848
1 parent 62e7f36
commit 9c1a848
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/...y-service/teletraanservice/src/main/java/com/pinterest/teletraan/worker/AgentJanitor.java b/...y-service/teletraanservice/src/main/java/com/pinterest/teletraan/worker/AgentJanitor.java
@@ -23,6 +23,7 @@
 import java.util.Map;
 import java.util.Set;
 
+import org.apache.commons.collections.CollectionUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -129,6 +130,11 @@ private void determineStaleHostCandidates() {
             LOG.error("failed to get unreachable hosts", ex);
             return;
         }
+
+        if (CollectionUtils.isEmpty(unreachableHosts)) {
+            return;
+        }
+
         ArrayList<String> unreachableHostIds = new ArrayList<>();
         unreachableHosts.stream().map(hostAgent -> unreachableHostIds.add(hostAgent.getHost_id()));
 
@@ -158,6 +164,10 @@ private void processStaleHosts() {
             return;
         }
 
+        if (CollectionUtils.isEmpty(staleHosts)) {
+            return;
+        }
+
         Map<String, HostAgentBean> staleHostMap = new HashMap<>();
         staleHosts.stream().map(hostAgent -> staleHostMap.put(hostAgent.getHost_id(), hostAgent));
 
@@ -193,6 +203,10 @@ private void cleanUpAgentlessHosts() {
             return;
         }
 
+        if (CollectionUtils.isEmpty(agentlessHosts)) {
+            return;
+        }
+
         Set<String> terminatedHosts = getTerminatedHostsFromSource(agentlessHosts);
         for (String hostId : agentlessHosts) {
             if (terminatedHosts.contains(hostId)) {