return bad request to customers if the http response code starts with…

… 4 (#1222) * return bad request to customers if the http response code starts with 4 * use Response.Status.Family.CLIENT_ERROR to check * Update deploy-service/teletraanservice/src/main/java/com/pinterest/teletraan/exception/GenericExceptionMapper.java Co-authored-by: Tyler Ouyang <[email protected]> --------- Co-authored-by: Tyler Ouyang <[email protected]>
pinterest · Jul 25, 2023 · 440f8c8 · 440f8c8
1 parent 8180a48
commit 440f8c8
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/...etraanservice/src/main/java/com/pinterest/teletraan/exception/GenericExceptionMapper.java b/...etraanservice/src/main/java/com/pinterest/teletraan/exception/GenericExceptionMapper.java
@@ -48,7 +48,13 @@ public Response toResponse(Throwable t) {
                 PrintWriter pw = new PrintWriter(sw);
                 t.printStackTrace(pw);
                 sb.append("\n").append(sw.toString());
-                return Response.serverError().entity(sb.toString()).build();
+                final Response response = ((WebApplicationException) t).getResponse();
+                Response.Status.Family family = response.getStatusInfo().getFamily();
+                if (family.equals(Response.Status.Family.CLIENT_ERROR)) {
+                    return Response.status(response.getStatus()).entity(sb.toString()).build();
+                } else {
+                    return Response.serverError().entity(sb.toString()).build();
+                }
             }
         } else if (t instanceof ConstraintViolationException) {
             StringBuilder sb = new StringBuilder();