New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1 Scheduled Jobs / Third Party Sync Migration #171

Open

mattwilshire wants to merge 53 commits into master from mattwilshire/v1-thirdparty-sync-migration

Member

mattwilshire commented Oct 23, 2024

Adds the ability to create scheduled jobs (currently only for third party syncs) that run off of a cron schedule.
Third party sync configurations are pulled from the application.properties and pushed to a new scheduled_job table.
The ScheduledJobManager handles the creation and deletion of jobs.
The job listener updates the status of each job pre and post execution.
New endpoints for fetching, triggering and toggling scheduled jobs.

mattwilshire requested review from maallen, byronantak, garionpin and DarKhaos

October 23, 2024 11:46

byronantak reviewed

View reviewed changes

webapp/src/main/resources/db/migration/V71__Add_scheduled_jobs.sql Outdated Show resolved Hide resolved

webapp/src/main/resources/db/migration/V71__Add_scheduled_jobs.sql Outdated Show resolved Hide resolved

byronantak reviewed

View reviewed changes

webapp/src/main/resources/db/migration/V71__Add_scheduled_jobs.sql Outdated Show resolved Hide resolved

byronantak reviewed

View reviewed changes

webapp/src/main/resources/db/migration/V71__Add_scheduled_jobs.sql Outdated Show resolved Hide resolved

byronantak reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/entity/ScheduledJob.java Outdated Show resolved Hide resolved

byronantak reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/entity/ScheduledJobStatusEntity.java Outdated Show resolved Hide resolved

byronantak reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/rest/scheduledjob/ScheduledJobWS.java Outdated Show resolved Hide resolved

byronantak reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/rest/scheduledjob/ScheduledJobWS.java Outdated Show resolved Hide resolved

byronantak reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/rest/scheduledjob/ScheduledJobWS.java Show resolved Hide resolved

byronantak reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/service/scheduledjob/jobs/ScheduledThirdPartySync.java Show resolved Hide resolved

byronantak reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/service/scheduledjob/jobs/ScheduledThirdPartySync.java Show resolved Hide resolved

byronantak reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/service/scheduledjob/jobs/ScheduledThirdPartySync.java Show resolved Hide resolved

byronantak reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/service/scheduledjob/jobs/ScheduledThirdPartySync.java Show resolved Hide resolved

byronantak reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/service/scheduledjob/jobs/ScheduledThirdPartySync.java Show resolved Hide resolved

byronantak reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/service/scheduledjob/ScheduledJobStatusRepository.java Outdated Show resolved Hide resolved

garionpin reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/entity/ScheduledJob.java Show resolved Hide resolved

garionpin reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/entity/ScheduledJob.java Outdated Show resolved Hide resolved

garionpin reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/entity/ScheduledJob.java Outdated Show resolved Hide resolved

garionpin reviewed

View reviewed changes

webapp/src/main/resources/db/migration/V71__Add_scheduled_jobs.sql Outdated Show resolved Hide resolved

garionpin reviewed

View reviewed changes

webapp/src/main/resources/db/migration/V71__Add_scheduled_jobs.sql Outdated Show resolved Hide resolved

garionpin reviewed

View reviewed changes

webapp/src/main/resources/db/migration/V71__Add_scheduled_jobs.sql Outdated Show resolved Hide resolved

garionpin reviewed

View reviewed changes

webapp/src/main/resources/db/migration/V71__Add_scheduled_jobs.sql Outdated Show resolved Hide resolved

garionpin reviewed

View reviewed changes

webapp/src/main/resources/db/migration/V71__Add_scheduled_jobs.sql Show resolved Hide resolved

garionpin reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/entity/ScheduledJob.java Show resolved Hide resolved

garionpin reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/entity/ScheduledJob.java Outdated Show resolved Hide resolved

garionpin reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/entity/ScheduledJobTypeEntity.java Outdated Show resolved Hide resolved

garionpin reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/rest/scheduledjob/ScheduledJobWS.java Outdated Show resolved Hide resolved

mattwilshire added 13 commits

October 31, 2024 12:17


          Review comments, ZonedDateTime & Foreign Key, BIT changes

685f707


          Capture PathVariable using UUID class

abd3493


          Review comment changes and refactoring

a7f7b1e


          Revert scheduler change

09c5460


          Change endpoints back to POST methods

217dd67


          Rename Job Status and Type, extra logging

40f9568


          Use HashSet instead of list, throw run time error if duplicate uuids …

26d3241

…are found


          Custom timeout for third party sync in application.properties

f43cf29


          Add metric for third party syncs that were scheduled and pagerduty in…

6e4f247

…cidents/resolves that fail.


          Renamed Status enum for WS response, disallow triggering disabled jobs

88aa990


          Added auto incremented primary key

97eaa0c


          Fix tests

9e0d560


          Small refactor

a9a1336

mattwilshire force-pushed the mattwilshire/v1-thirdparty-sync-migration branch from 0b9f4fa to a9a1336 Compare

October 31, 2024 12:18

mattwilshire added 2 commits

November 1, 2024 11:09


          Remove unique key, added insert statements for hsqldb

88fa2ea


          Log pollable task and scheduled job url on PD failure

069b660

byronantak reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/service/scheduledjob/ScheduledJobTriggerListener.java Outdated Show resolved Hide resolved

webapp/src/main/java/com/box/l10n/mojito/service/scheduledjob/ScheduledJobTypeRepository.java Outdated Show resolved Hide resolved

webapp/src/main/java/com/box/l10n/mojito/service/scheduledjob/ScheduledJobProperties.java Show resolved Hide resolved

webapp/src/main/java/com/box/l10n/mojito/service/scheduledjob/ScheduledJobRepository.java Outdated Show resolved Hide resolved

webapp/src/main/java/com/box/l10n/mojito/entity/ScheduledJob.java Outdated Show resolved Hide resolved

webapp/src/main/java/com/box/l10n/mojito/entity/ScheduledJobStatus.java Show resolved Hide resolved

webapp/src/main/java/com/box/l10n/mojito/entity/ScheduledJobType.java Show resolved Hide resolved

webapp/src/main/java/com/box/l10n/mojito/entity/ScheduledJobType.java Show resolved Hide resolved

mattwilshire added 2 commits

November 4, 2024 17:04


          Added Integration Tests, Unique key on UUID column

78167c4


          Constructor Autowire for WS

fd4ba88

mattwilshire marked this pull request as ready for review

November 4, 2024 18:21

mattwilshire requested a review from a team as a code owner

November 4, 2024 18:21

garionpin reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/rest/scheduledjob/ScheduledJobWS.java Outdated Show resolved Hide resolved

maallen reviewed

View reviewed changes

webapp/src/main/java/com/box/l10n/mojito/entity/ScheduledJob.java Outdated Show resolved Hide resolved

webapp/src/main/java/com/box/l10n/mojito/rest/scheduledjob/ScheduledJobWS.java Show resolved Hide resolved

webapp/src/main/java/com/box/l10n/mojito/entity/ScheduledJob.java Outdated Show resolved Hide resolved

mattwilshire added 4 commits

November 6, 2024 13:18


          Update tests to use ID watcher and removed redundant tests

91912ac


          Adding queuing up a manual re-trigger

59ec8b1


          Only set job status as Scheduled if the job was only inserted into th…

20c2c02

…e db now


          Extend base entity and rename to isEnabled

39da1bf

garionpin approved these changes

View reviewed changes

byronantak approved these changes

View reviewed changes


          Use waitForPollableTask instead of task.get()

47cb1c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet