Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix group can add operations and set completion multiple times when the group start. #22

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix group can add operations and set completion multiple times when the group start. #22

wants to merge 3 commits into from

Conversation

kinarobin
Copy link

@kinarobin kinarobin commented Jun 21, 2019 •
edited
Loading

Thanks for pinterest contribution to open source!

And I found a _start flag that never used, So I hope to remove it.

@garrettmoon
Copy link
Collaborator

Ah! I think you've actually found a bug! I think _started should be set to YES when the group starts, otherwise it can be run multiple times!

@kinarobin
Copy link
Author

Once the group start, the _operations = nil is executing. So it not run multiple times. But when the group start, it still can add operations and set completion, It was a bug. I will change the code.

@kinarobin kinarobin changed the title Delete unused flag in operation group. Fix group can add operations and set completion multiple times when the group start. Jun 22, 2019
@garrettmoon
Copy link
Collaborator

I'm so sorry this never got merged :( Any chance you can rebase it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kinarobin @garrettmoon