activemerchant#5133)

Spreedly ref: ECS-3536

Summary:
------------------------------
Add unit and remote tests for network token transactions

[SER-1270](https://spreedly.atlassian.net/browse/SER-1270)

Remote Test:
------------------------------
Finished in 88.332434 seconds.
60 tests, 261 assertions, 0 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
100% passed

Unit Test:
------------------------------
Finished in 45.844644 seconds.
5931 tests, 79847 assertions, 0 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
100% passed

RuboCop:
------------------------------
798 files inspected, no offenses detected

SER-1302

Description
-------------------------
Add support to make verify transactions with authorize and void using a multiresponse thread

Unit test
-------------------------
25 tests, 136 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote test
-------------------------
23 tests, 57 assertions, 2 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
90.9091% passed

Rubocop
-------------------------
798 files inspected, no offenses detected

…t#4720)

Co-authored-by: Huda <[email protected]>

[ECS-3450](https://spreedly.atlassian.net/browse/ECS-3450)

This PR updates adds stored credendials and 3ds exemptions for redsys rest

Unit tests
----------------
Finished in 0.023518 seconds.

28 tests, 118 assertions, 0 failures,
0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote tests
----------------
Finished in 33.326868 seconds.

26 tests, 93 assertions, 1 failures,
0 errors, 0 pendings, 0 omissions, 0 notifications
96.1538% passed

0.78 tests/s, 2.79 assertions/s

-> failure not related to changes

Description
-------------------------
SER-1323
Unit test
-------------------------
25 tests, 136 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote test
-------------------------
23 tests, 57 assertions, 2 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
90.9091% passed

Account Funding Transactions, which Worldpay refers to as "Pull from
Card"
https://staging-developer.fisglobal.com/apis/wpg/manage/pull-from-card

Remote: (10 unrelated failures on master)
110 tests, 443 assertions, 10 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
90.9091% passed

Unit:
124 tests, 698 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

ECS-3554

Always send commerceIndicator if stored
credential reason_type is present. Update
the value send for NetworkTokens commerceIndicator
based on if they are using stored credentials.

Spreedly reference:
[ECS-3532](https://spreedly.atlassian.net/browse/ECS-3532)

Unit tests

Finished in 26.745895 seconds.
5912 tests, 79756 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

RuboCop

798 files inspected, no offenses detected

If alternate_ucaf_flow is true and the eci value is 4, 6, or 7 then
send the ucaf passed in by customer. If alternate_ucaf_flow is not
passed then only send ucaf if provided by customer if not pass default
of 4.

Remote:
134 tests, 543 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Unit:
152 tests, 892 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Summary:
------------------------------
Changes FlexCharge to add support for the authorize and
capture operations and also a fix a bug on the `address_names`
method

[SER-1337](https://spreedly.atlassian.net/browse/SER-1337)
[SER-1324](https://spreedly.atlassian.net/browse/SER-1324)

Remote Test:
------------------------------
Finished in 72.283834 seconds.
19 tests, 54 assertions, 1 failures, 0 errors, 0 pendings,
1 omissions, 0 notifications
94.4444% passed

Unit Tests:
------------------------------
Finished in 43.11362 seconds.
5944 tests, 79908 assertions, 0 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
100% passed

RuboCop:
------------------------------
798 files inspected, no offenses detected

Summary:
------------------------------
Changes FlexCharge to add support for the void operation.

[SER-1327](https://spreedly.atlassian.net/browse/SER-1327)

Remote Test:
------------------------------
Finished in 70.477035 seconds.
19 tests, 54 assertions, 0 failures, 0 errors, 0 pendings,
1 omissions, 0 notifications
100% passed

Unit Tests:
------------------------------
Finished in 60.782586 seconds.
5956 tests, 79948 assertions, 0 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
100% passed

RuboCop:
------------------------------
798 files inspected, no offenses detected

CER-1567

Sends code '058' for carnet card type in legacy CyberSource and CyberSource REST gateways

Updae customerPhone to grab phone from phone or phone_number
in options. If address doesn't contain ip and email then grab them
directly from options. Add new field called storeID.

Unit:
29 tests, 164 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
20 tests, 106 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Update so that if a 3DS version starts with 2 it doesn't
default to 2.0 but on what is passed in for the three_ds_version
field.

Unit:
82 tests, 394 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
51 tests, 173 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
88.2353% passed

Description
-------------------------
SER-1339

Unit test
-------------------------
17 tests, 81 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote test
-------------------------
5923 tests, 79804 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

RuboCop:
------------------------------
798 files inspected, no offenses detected

Co-authored-by: Nick Ashton <[email protected]>

FlexCharge: Enabling void call

Summary:
------------------------------
Changes FlexCharge to fix support for the void operation and
also add the sense_key gsf

[SER-1327](https://spreedly.atlassian.net/browse/SER-1327)
[SER-1307](https://spreedly.atlassian.net/browse/SER-1307)

Remote Test:
------------------------------
Finished in 70.477035 seconds.
19 tests, 54 assertions, 0 failures, 0 errors, 0 pendings,
1 omissions, 0 notifications
100% passed

Unit Tests:
------------------------------
Finished in 124.425603 seconds.
5959 tests, 79971 assertions, 0 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
100% passed

RuboCop:
------------------------------
798 files inspected, no offenses detected

…the payment value was a token (activemerchant#5173)

Update Stored Credential flow to keep v2.

Unit:
104 tests, 219 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
123 tests, 661 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Description
-------------------------
[SER-1377](https://spreedly.atlassian.net/browse/SER-1377)

This commit update the previous implementation of NT in order to use
network token instead if card

Unit test
-------------------------
Finished in 0.033159 seconds.

25 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

753.94 tests/s, 4131.61 assertions/s

Remote test
-------------------------
Finished in 47.41717 seconds.

32 tests, 62 assertions, 0 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications
100% passed

0.67 tests/s, 1.31 assertions/s

Rubocop
-------------------------
798 files inspected, no offenses detected

Co-authored-by: Javier Pedroza <[email protected]>

Description
-------------------------
This commit add support to create transaction with GooglePay and
ApplePay.
This payment methods are working for nmi_secure.

Unit test
-------------------------
Finished in 11.283174 seconds.

59 tests, 475 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications

100% passed

5.23 tests/s, 42.10 assertions/s

Remote test
-------------------------
Finished in 115.513346 seconds.

55 tests, 199 assertions, 12 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications

78.1818% passed

0.48 tests/s, 1.72 assertions/s

Rubocop
-------------------------
798 files inspected, no offenses detected

Co-authored-by: Javier Pedroza <[email protected]>

…rchant#5166)

Summary:
------------------------------
Add merchant_account_id for the Client Token Generate and returns a string which contains all authorization and configuration information that the client needs to initialize the client SDK to communicate with Braintree

[ECS-3617](https://spreedly.atlassian.net/browse/ECS-3617)
[ECS-3607](https://spreedly.atlassian.net/browse/ECS-3607)

Remote Test:
------------------------------
Finished in 6.262003 seconds.
7 tests, 15 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
1.12 tests/s, 2.40 assertions/s

Unit Tests:
------------------------------
Finished in 38.744354 seconds.
5956 tests, 79952 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
153.73 tests/s, 2063.58 assertions/s

RuboCop:
------------------------------
798 files inspected, no offenses detected

Co-authored-by: Luis Urrea <[email protected]>

Update crypt_type to only be one digit by removing leading zero
if present.

Unit:
54 tests, 294 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
53 tests, 259 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
100% passed

Update CheckoutV2 3DS message & error code to keep
waht was bening threed_response_message

Unit:
67 tests, 420 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
111 tests, 274 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Summary:
------------------------------
FlexCharge: quick fix on void call

[SER-1386](https://spreedly.atlassian.net/browse/SER-1386)

Remote Test:
------------------------------
Finished in 70.477035 seconds.
19 tests, 54 assertions, 0 failures, 0 errors, 0 pendings,
1 omissions, 0 notifications
100% passed

Unit Tests:
------------------------------
Finished in 124.425603 seconds.
5959 tests, 79971 assertions, 0 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
100% passed

RuboCop:
------------------------------
798 files inspected, no offenses detected

Summary:
------------------------------
FlexCharge:

Including shipping address if provided and fix idempotency key
to default to random UUID.

[SER-1387](https://spreedly.atlassian.net/browse/SER-1387)
[SER-1338](https://spreedly.atlassian.net/browse/SER-1338)

Remote Test:
------------------------------
Finished in 77.783815 seconds.
20 tests, 56 assertions, 0 failures, 0 errors, 0 pendings,
1 omissions, 0 notifications
100% passed

Unit Tests:
------------------------------
Finished in 46.32943 seconds.
5963 tests, 79998 assertions, 0 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
100% passed

RuboCop:
------------------------------
798 files inspected, no offenses detected

Summary:
_________________________
Include Store and Unstore Methods in datatrans
to support Third Party Token.

[SER-1395](https://spreedly.atlassian.net/browse/SER-1395)

Tests
_________________________

Remote Test:
-------------------------
Finished in 31.477035 seconds.
27 tests, 76 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
100% passed

Unit Tests:
-------------------------
Finished in 0.115603 seconds.
29 tests, 165 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Rubocop
-------------------------
798 files inspected, no offenses detected

Summary:
------------------------------
Change FlexCharge transactionType to a new placement.

[SER-1400](https://spreedly.atlassian.net/browse/SER-1400)

Remote Test:
------------------------------
Finished in 79.263845 seconds.
20 tests, 56 assertions, 0 failures, 0 errors, 0 pendings,
1 omissions, 0 notifications
100% passed

Unit Tests:
------------------------------
Finished in 38.175694 seconds.
5963 tests, 79998 assertions, 0 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
100% passed

RuboCop:
------------------------------
798 files inspected, no offenses detected

CER-1613

Top level boolean field that will trigger payment method to be saved.

Remote Tests:
54 tests, 152 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
94.4444% passed
* I fixed a few failing tests, so less failing on master.

…#5193)

Summary:
Modify the string for store to be separated by '|' instead of
'-'.

SER-1395

Tests
Remote Test:
Finished in 31.477035 seconds.
25 tests, 72 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
100% passed

Unit Tests:
Finished in 0.115603 seconds.
29 tests, 165 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Rubocop
798 files inspected, no offenses detected

Co-authored-by: Gustavo Sanmartin <[email protected]>

Add safety navigator to error_message to prevent NoMethod errors and
create a validation_error_message to construct a new error message.

To satisfy new Elavon API requirements, including recurring_flag,
approval_code for non-tokenized PMs, installment_count and _number, and
situational par_value and association_token_data fields.

Remote
40 tests, 178 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
95% passed

Unit
60 tests, 356 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Only skip CVV if stored credentials is being used and it's
not an initial transaction.

…#5197)

Summary:
------------------------------
Rename the equivalent ds_transaction_id in fatzebra for
directory_server_txn_id, to map it corrctly.

[ECS-3660](https://spreedly.atlassian.net/browse/ECS-3660)
[UBI-132](https://spreedly.atlassian.net/browse/UBI-132)

Remote Tests:
------------------------------
Finished in 87.765183 seconds.
30 tests, 104 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
93.3333% passed

*Note Failing Test*: We have to remote tests failing because seems to be a change on the sandbox behavior when a transaction doesn't include a cvv

Unit Tests:
------------------------------
Finished in 0.073139 seconds.
23 tests, 130 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

RuboCop:
------------------------------
798 files inspected, no offenses detected

Co-authored-by: Gustavo Sanmartin <[email protected]>

…emerchant#5181)

* Upgrade rexml to 3.3.2

This resolves CVE-2024-39908 : DoS in REXML

* Apply suggestion

* Fix tests

* Upgrade rexml to 3.3.4

…chant into sync-upstream-5-aug-2024