Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes with improvements to window state handling (floating, fullscreen, maximized).
Improvements include:
_JAVA_AWT_WM_NONREPARENTING=1
to get it to appear correctlyThings that need doing and thinking about:
WindowElementState::floating_or_tiled
is doing. It's currently pulling double duty as the holder for the current floating/tiled state of the window and it gets used as a marker for what state gets applied when exiting fullscreen or tiled mode; both "prescription" and "description". Find a way to separate its duties.floating_or_tiled
with thefullscreen_or_maximized
state, which now feeds intoPinnacle::update_window_state
.enum { Tiled, Floating, Fullscreen, Maximized }